Skip to content

Commit 965bba8

Browse files
committed
Fix tags not appearing in share sidebar
In the edit tags component, the item tags were mapped and filtered to only match tags that were present on the current archive. This seems to be redundant for items that are in the private workspace, because the tags on the item and the tags on the archive have the same type TagVOData. However, the mapping and filtering would eliminate all tags for the shared items, because none of them would be present in the archive's tags. In conclusion, eliminating the mapping/filtering would not affect the private workspace and will fix the shared workspace tags. Issue: PER-10365 Keywords and metadata should show in the sidebar for Share Files section
1 parent d867a9e commit 965bba8

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

src/app/file-browser/components/edit-tags/edit-tags.component.ts

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -231,12 +231,10 @@ export class EditTagsComponent
231231
this.itemTagsById.clear();
232232

233233
this.itemTags = this.filterTagsByType(
234-
(this.item?.TagVOs || [])
235-
.map((tag) => this.allTags?.find((t) => t.tagId === tag.tagId))
236-
.filter(
237-
// Filter out tags that are now null from deletion
238-
(tag) => tag?.name,
239-
),
234+
(this.item?.TagVOs || []).filter(
235+
// Filter out tags that are now null from deletion
236+
(tag) => tag?.name,
237+
),
240238
);
241239

242240
if (!this.item?.TagVOs?.length) {

0 commit comments

Comments
 (0)