-
Notifications
You must be signed in to change notification settings - Fork 715
Initial V0.44 changelog parsing #8766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8766 +/- ##
=======================================
Coverage 99.37% 99.37%
=======================================
Files 589 589
Lines 63237 63237
=======================================
Hits 62842 62842
Misses 395 395 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
isaacdevlugt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Gabriela! Nice work 🚀!
There are a couple sections I think we can remove and a couple sections I think we can add based on new features that haven't been merged into master yet 😁.
DSGuala
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I can approve as soon as current comments are addressed
isaacdevlugt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! We're gettin' there 💪 just some more minor refinements to go and then we should be set to merge this!
isaacdevlugt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Once all comments / suggestions are resolved we're ready to go 💪
DSGuala
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
No description provided.