-
-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Cancellable connection establish event #1085
Open
kezz
wants to merge
1
commit into
PaperMC:dev/3.0.0
Choose a base branch
from
kezz:feature/cancel-handshake
base: dev/3.0.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
76 changes: 76 additions & 0 deletions
76
api/src/main/java/com/velocitypowered/api/event/connection/ConnectionEstablishEvent.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,76 @@ | ||
/* | ||
* Copyright (C) 2018-2021 Velocity Contributors | ||
* | ||
* The Velocity API is licensed under the terms of the MIT License. For more details, | ||
* reference the LICENSE file in the api top-level directory. | ||
*/ | ||
|
||
package com.velocitypowered.api.event.connection; | ||
|
||
import com.google.common.base.Preconditions; | ||
import com.velocitypowered.api.event.ResultedEvent; | ||
import com.velocitypowered.api.event.annotation.AwaitingEvent; | ||
import com.velocitypowered.api.proxy.InboundConnection; | ||
import org.checkerframework.checker.nullness.qual.NonNull; | ||
import org.checkerframework.checker.nullness.qual.Nullable; | ||
|
||
/** | ||
* Event called when a connection is initially established with the proxy. | ||
* Velocity will wait for this event to fire before continuing with the connection. | ||
*/ | ||
@AwaitingEvent | ||
public class ConnectionEstablishEvent implements ResultedEvent<ResultedEvent.GenericResult> { | ||
private final InboundConnection connection; | ||
private final Intention intention; | ||
private GenericResult result = GenericResult.allowed(); | ||
|
||
public ConnectionEstablishEvent( | ||
final @NonNull InboundConnection connection, | ||
final @Nullable Intention intention | ||
) { | ||
this.connection = Preconditions.checkNotNull(connection, "connection"); | ||
this.intention = intention; | ||
} | ||
|
||
/** | ||
* The intention of the connection. | ||
*/ | ||
public enum Intention { | ||
/** | ||
* The user intends to ping the server to fetch the status. | ||
*/ | ||
STATUS, | ||
/** | ||
* The user intends to log in to the server. | ||
*/ | ||
LOGIN, | ||
} | ||
|
||
/** | ||
* Returns the inbound connection that is being established. | ||
* | ||
* @return the connection | ||
*/ | ||
public @NonNull InboundConnection getConnection() { | ||
return this.connection; | ||
} | ||
|
||
/** | ||
* Returns the intention for which the connection is being established, if known. | ||
* | ||
* @return the intention | ||
*/ | ||
public @Nullable Intention getIntention() { | ||
return this.intention; | ||
} | ||
|
||
@Override | ||
public GenericResult getResult() { | ||
return this.result; | ||
} | ||
|
||
@Override | ||
public void setResult(final @NonNull GenericResult result) { | ||
this.result = Preconditions.checkNotNull(result, "result"); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If
getIntentionForStatus
returns null, I would prefer if we just closed the connection right then and there. But I can understand why we might want to check for an invalid status.