-
-
Notifications
You must be signed in to change notification settings - Fork 647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Cancellable connection establish event #1085
base: dev/3.0.0
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good pull request. A feature that you need, in my opinion.
api/src/main/java/com/velocitypowered/api/event/connection/ConnectionEstablishEvent.java
Outdated
Show resolved
Hide resolved
api/src/main/java/com/velocitypowered/api/event/connection/ConnectionEstablishEvent.java
Outdated
Show resolved
Hide resolved
The event should include the intention of the connection. |
0cc54ef
to
7c77026
Compare
I'm just going to leave this one, it's a better code style that is less error prone. Other event classes, for example, do not have nullness annotations, we shouldn't follow that just because they use that style.
Thanks, edited this and it should be good now. |
server.getEventManager() | ||
.fire(new ConnectionEstablishEvent( | ||
ic, getIntentionForStatus(handshake.getNextStatus()))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If getIntentionForStatus
returns null, I would prefer if we just closed the connection right then and there. But I can understand why we might want to check for an invalid status.
Don't know if it makes more sense to do something else that isn't blocking on this event firing - couldn't really think of a better way to handle it. Potential for this to be expanded in the future to distinguish between ping vs. connection.