new: manipbolt #175
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,101 @@ | ||
| package manipbolt | ||
|
|
||
| import ( | ||
| "fmt" | ||
|
|
||
| "github.com/asdine/storm/q" | ||
| "go.aporeto.io/elemental" | ||
| "go.aporeto.io/manipulate" | ||
| ) | ||
|
|
||
| func compileFilter(f *elemental.Filter) (q.Matcher, error) { | ||
|
|
||
| if len(f.Operators()) == 0 { | ||
| return q.And(), nil | ||
| } | ||
|
|
||
| matchers := []q.Matcher{} | ||
|
|
||
| for i, operator := range f.Operators() { | ||
|
|
||
| switch operator { | ||
|
|
||
| case elemental.AndOperator: | ||
|
|
||
| k := f.Keys()[i] | ||
| values := f.Values()[i] | ||
| items := []q.Matcher{} | ||
|
|
||
| switch f.Comparators()[i] { | ||
|
|
||
| case elemental.EqualComparator: | ||
|
|
||
| items = append(items, containsOrEqual(k, values[0])) | ||
|
There was a problem hiding this comment. I haven't checked that function yet, but either it is not doing what it says it does (equality check) or should not be used. From what I understand, a == "y" would match x if x == "ay" |
||
|
|
||
| case elemental.MatchComparator: | ||
|
|
||
| subs := []q.Matcher{} | ||
| for _, value := range values { | ||
|
|
||
| v, ok := value.(string) | ||
| if !ok { | ||
| return nil, manipulate.ErrCannotBuildQuery{Err: fmt.Errorf("regex only supports string: %v", value)} | ||
| } | ||
|
|
||
| subs = append(subs, regexMatcher(k, v)) | ||
| } | ||
|
|
||
| items = append(items, q.Or(subs...)) | ||
|
There was a problem hiding this comment. Please check or is the behavior of other filter compilers. |
||
|
|
||
| case elemental.ContainComparator: | ||
|
There was a problem hiding this comment. this should also be the behavior for elemental.InComparator |
||
|
|
||
| subs := []q.Matcher{} | ||
| for _, value := range values { | ||
| subs = append(subs, containsOrEqual(k, value)) | ||
| } | ||
|
|
||
| items = append(items, q.Or(subs...)) | ||
|
|
||
| default: | ||
| return nil, manipulate.ErrCannotBuildQuery{Err: fmt.Errorf("invalid comparator: %d", f.Comparators()[i])} | ||
| } | ||
|
|
||
| matchers = append(matchers, items...) | ||
|
|
||
| case elemental.AndFilterOperator: | ||
|
|
||
| subs := []q.Matcher{} | ||
| for _, sub := range f.AndFilters()[i] { | ||
|
|
||
| matcher, err := compileFilter(sub) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| subs = append(subs, matcher) | ||
| } | ||
|
|
||
| matchers = append(matchers, q.And(subs...)) | ||
|
|
||
| case elemental.OrFilterOperator: | ||
|
|
||
| subs := []q.Matcher{} | ||
| for _, sub := range f.OrFilters()[i] { | ||
|
|
||
| matcher, err := compileFilter(sub) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| subs = append(subs, matcher) | ||
| } | ||
|
|
||
| matchers = append(matchers, q.Or(subs...)) | ||
|
|
||
| default: | ||
| return nil, manipulate.ErrCannotBuildQuery{Err: fmt.Errorf("invalid operator: %d", operator)} | ||
| } | ||
| } | ||
|
|
||
| return q.And(matchers...), nil | ||
| } | ||
|
There was a problem hiding this comment. this misses other basic comparators, namely
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please stay on releases