new: manipbolt #175
new: manipbolt #175
Conversation
|
/build |
| @@ -3,41 +3,50 @@ module go.aporeto.io/manipulate | |||
| go 1.20 | |||
|
|
|||
| require ( | |||
| go.aporeto.io/elemental v1.122.0 | |||
| go.aporeto.io/wsc v1.51.0 | |||
| go.aporeto.io/elemental v1.122.1-0.20230127211758-51fb47178716 | |||
There was a problem hiding this comment.
please stay on releases
| go.aporeto.io/elemental v1.122.0 | ||
| go.aporeto.io/wsc v1.51.0 | ||
| go.aporeto.io/elemental v1.122.1-0.20230127211758-51fb47178716 | ||
| go.aporeto.io/wsc v1.51.1-0.20230127211509-870916470c0c |
There was a problem hiding this comment.
please stay on releases
| return &config{} | ||
| } | ||
|
|
||
| // OptionCodec used to set a custom encoder and decoder. |
There was a problem hiding this comment.
| // OptionCodec used to set a custom encoder and decoder. | |
| // OptionCodec sets a custom encoder and decoder. |
|
|
||
| case elemental.EqualComparator: | ||
|
|
||
| items = append(items, containsOrEqual(k, values[0])) |
There was a problem hiding this comment.
I haven't checked that function yet, but either it is not doing what it says it does (equality check) or should not be used. From what I understand, a == "y" would match x if x == "ay"
| subs = append(subs, regexMatcher(k, v)) | ||
| } | ||
|
|
||
| items = append(items, q.Or(subs...)) |
There was a problem hiding this comment.
Please check or is the behavior of other filter compilers.
|
|
||
| items = append(items, q.Or(subs...)) | ||
|
|
||
| case elemental.ContainComparator: |
There was a problem hiding this comment.
this should also be the behavior for elemental.InComparator
| } | ||
|
|
||
| return q.And(matchers...), nil | ||
| } |
There was a problem hiding this comment.
this misses other basic comparators, namely
- elemental.NotEqualComparator
- elemental.NotContainComparator
- elemental.NotInComparator
- elemental.GreaterComparator
- elemental.GreaterOrEqualComparator
- elemental.LesserComparator
- elemental.GreaterOrEqualComparator
- elemental.ExistsComparator
- elemental.NotExistsComparator
| { | ||
| name: "invalid filter", | ||
| args: args{ | ||
| elemental.NewFilterComposer().WithKey("pid").NotEquals("5d83e7eedb40280001887565").Done(), |
There was a problem hiding this comment.
You should test those against the String() version of the filter
Created by: sibicramesh
manipbolt implements a schema less persistent storage backed by boltdb+storm. It implements manipulate interface.
To begin
To create a new manipbolt
Thats it!
Features
manipulate.ContextOptionTransactionID(tid), don't forget to callm.Commit(tid)orm.Abort(tid)once you're done with a transaction. Only one rw transaction can be active at a time.and much more.
Error handling
manipulate.Error. The underlying error is part of the Error() method`.Unit tests
Unit test coverage is ~95%.
Inspired by
https://github.com/asdine/storm
https://github.com/etcd-io/bbolt
https://github.com/aporeto-inc/manipulate