Build with C++17 so the bridge compiles against JSBSim 1.3#18
Open
Blandingo wants to merge 1 commit into
Open
Conversation
JSBSim 1.3.x headers use C++17 library features (std::is_enum_v in FGPropertyManager.h), so building the bridge against a current JSBSim release fails while CMAKE_CXX_FLAGS pins -std=c++14. Raise the standard to C++17; no source changes are needed. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
JSBSim 1.3.x headers use C++17 library features — e.g.
std::is_enum_vininput_output/FGPropertyManager.h— so compiling the bridge against any current JSBSim release fails whileCMAKE_CXX_FLAGSpins-std=c++14:Fix
Raise the standard to C++17 in
CMakeLists.txt. No source changes are needed; the bridge sources compile unchanged.Validation
Built and flown against JSBSim v1.3.1 in a PX4 v1.17.0 SITL lockstep pipeline (fixed-wing catapult-launch scenario); our smoke and flight-metric gates pass with the bridge built as C++17 against both JSBSim v1.2.3 and v1.3.1.
Independent of #17, applies cleanly either way.