-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New function save_to_gh()
#5
Open
RossanaTat
wants to merge
13
commits into
DEV_v2
Choose a base branch
from
new_save_to_gh_RT
base: DEV_v2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+402
−186
Open
Changes from 11 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
9955790
new function first part
RossanaTat ab334a9
complete function and fix issues with updating data
RossanaTat 74e350a
more fixes on new function
RossanaTat 3598a88
documentation
RossanaTat 4f84c45
new tests
RossanaTat 544badd
more tests and ensure they pass across sessions
RossanaTat 9c4dcca
clean code
RossanaTat 04d1746
more cleaning on test
RossanaTat 963eb4e
rm old tests
RossanaTat 2641024
fix default extension and documentation
RossanaTat 7f42e14
update vignette based on new function
RossanaTat 8d18ea1
rm redundant code
RossanaTat 46ef24f
fixes to tests
RossanaTat File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is unnecessary because both gh and cli should be part of the namespace of this package. As long as these packages are in the
imports
section of the DESCRPTION file, you don't need to add these lines of code. Thanks.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @randrescastaneda, thank you for reviewing. That's right, those lines are redundant because both
cli
andgh
are in the Imports section. I removed them and pushed again.