New function save_to_gh()
#5
Conversation
R/save_to_gh.R
Outdated
| if (!requireNamespace("gh", quietly = TRUE)) { | ||
| stop("Package 'gh' is required. Please install it using install.packages('gh').") | ||
| } | ||
|
|
||
| if (!requireNamespace("cli", quietly = TRUE)) { | ||
| install.packages("cli") | ||
| library(cli) | ||
| } | ||
|
|
There was a problem hiding this comment.
This is unnecessary because both gh and cli should be part of the namespace of this package. As long as these packages are in the imports section of the DESCRPTION file, you don't need to add these lines of code. Thanks.
There was a problem hiding this comment.
Hi @randrescastaneda, thank you for reviewing. That's right, those lines are redundant because both cli and gh are in the Imports section. I removed them and pushed again.
There was a problem hiding this comment.
Hi @RossanaTat, The changes look great, thank you so much. I added A comment about a few lines that I don't think should be there. but please let me know if you disagree. Otherwise, just. make the change and push again.
|
Hi @RossanaTat, |
|
Hi @randrescastaneda, I've addressed the changes you suggested and pushed again. Tests on the new |
There was a problem hiding this comment.
Hi @RossanaTat,
Thank you. I checked the PR, and it seems to me that we need to fix the issues of the check() before merging. I ran it myself and there are many things that are failing. Could you please take care of the issues? If they are difficult to solve, please let me know and we find a way to fix them soom. Thanks.
This PR fixes and improves the old save_to_gh() function. The updated version builds on the original, making sure it works in all cases. The main issue was that it wouldn’t update the data of an existing file, but now it works for all scenarios:
Key improvements also include better handling of metadata and making sure it’s checked properly when it’s provided.
This PR also adds new tests and updates the vignette, specifically the "Saving Data to GitHub" section in
interact_with_Github.Rmd.