Data Localization

[hishamco]

Fixes #3607

[hishamco]

I'm successfully able to export the dynamic data localization, here's what I got:

{
  "name": "",
  "displayName": "",
  "description": "",
  "author": "",
  "website": "",
  "version": "",
  "issetuprecipe": false,
  "categories": "",
  "tags": [],
  "steps": [
    {
      "name": "DynamicDataTranslations",
      "DynamicDataTranslations": {
        "Article1": {
          "en": "Article1",
          "fr": "Article1",
          "es": "Artículo1"
        },
        "Article2": {
          "en": "Article2",
          "fr": "Article2",
          "es": ""
        },
        "Article3": {
          "en": "",
          "fr": "",
          "es": "Artículo3"
        }
      }
    }
  ]
}

It's the time to tweak it little to add the group them by the context

[hishamco]

@sebastienros any comments here before I will move further

/cc @jtkech @jptissot @Skrypt

[jrestall]

@sebastienros any comments or should @hishamco keep going? Would love to see this one keep moving but it's dropped to the second page of PRs 😟

[sebastienros]

I had started to review ... will go on don't worry, very important

[hishamco]

@sebastienros you asked me from the beginning to keep you in the loop, seem I enter in infinite loop 😄

[hishamco]

@sebastienros any change to review this before 1.0.0 or shall we delay to 1.1.0?

[agriffard]

Conflicts to resolve.

[hishamco]

Sure, I will resolve them, but still need more work here, IMHO if this feature will be after 1.0.0 I can try to finalize it and ship it in Orchard Core Contrib at least we have a preview there, unless @sebastienros has another suggestion about when this feature should be shipped. Furthermore I think DataAnnotations Localization could go in 1.0.0 to avoid any breaking changes later

Thanks

[Skrypt]

@hishamco This PR looks like a good start but where is the UI/Views/Controllers for adding translations on a Content Type or Field names? Ok, getting back on this tomorrow. Will test it and try to add some UI.

[hishamco]

I just waiting for Seb at that time ;) I can implement this feature in OCC and provide a worked prototype

[Skrypt]

It definitely needs to be added to OC.

[hishamco]

It definitely needs to be added to OC.

Me too ;) what I'm suggested is to make real working prototype in OCC, after that we can continue here and hear the OC team opinions

BTW this supposed to be 1.1.0 feature If I remembered

[Skrypt]

I think everyone will agree that we should not wait on 1.0 to start working on something 😅
I don't know about OC Contrib. I think this should be part of OC right out of the box.

[hishamco]

I don't know about OC Contrib. I think this should be part of OC right out of the box.

OCC is provide non official modules, themes and features for OC, of course this will be a part of OC but it needs a time to review and merge, I will try to keep this updated until Seb have a time to revise this

[hishamco]

It's ready for review, also I need to update something before merging. FYI while the PR is too old and very useful we can merge it with minimalist features, then I can continue pushing new features

I already did a great progress in OCC, also I might need to do another demo perhaps to accelerate the merging process :)

[Piedone]

Awesome! @sebastienros would you like to continue the review?

[hishamco]

This is for you Seb #4466 (comment) :)

[Mollenhorst]

It's ready for review, also I need to update something before merging. FYI while the PR is too old and very useful we can merge it with minimalist features, then I can continue pushing new features

I already did a great progress in OCC, also I might need to do another demo perhaps to accelerate the merging process :)

It's ready for review, also I need to update something before merging. FYI while the PR is too old and very useful we can merge it with minimalist features, then I can continue pushing new features

I already did a great progress in OCC, also I might need to do another demo perhaps to accelerate the merging process :)

If you are planning a short demo on this, consider joining me into this call.

[hishamco]

@Mollenhorst sure I will do that, but my demo is follow-up, if you need related demos I can share the links, also I demo the Data Localization on the previous Orchard Harvest Conf

[github-actions]

This pull request has merge conflicts. Please resolve those before requesting a review.

[github-actions]

It seems that this pull request didn't really move for quite a while. Is this something you'd like to revisit any time soon or should we close? Please comment if you'd like to pick it up.

[github-actions]

This pull request has merge conflicts. Please resolve those before requesting a review.

[MikeAlhayek]

for instructions on how to resolve the merge conflicts due to #16572 please follow the step listed in this comment.

[github-actions]

It seems that this pull request didn't really move for quite a while. Is this something you'd like to revisit any time soon or should we close? Please comment if you'd like to pick it up.

[hishamco]

I think this should be a part of OC 3.0.0

[Piedone]

Does it have/need breaking changes?

[hishamco]

Does it have/need breaking changes?

I don't think so, but I need to revise the PR and see the updates that I did in OCC

[github-actions]

It seems that this pull request didn't really move for quite a while. Is this something you'd like to revisit any time soon or should we close? Please comment if you'd like to pick it up.