-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Defining fields of special content part or content types for all available cultures. #4712
Comments
You 're right, we already implment
Is that mean they are not change if the current culture changed? |
As an example, when we choose a text for hint field in en-US culture, that text will be shown for other cultures too. I think it’s better to be able to choose that text for each culture separately. So, When we change the culture in CMS, Everything will look nice. |
Make sense, is there anything else except Hint |
@hishamco Display Name is so important too! It would be great, If we could define Display Name and Hint text for other cultures too, while defining new content part or content type. In this photo, all of these content types has been defined when the default culture of CMS was en-US. When i changed the culture to fa-IR, it doesn't look nice. As you can see in the top right cornet of the page, the title of the website in fa-IR culture is English. I think we must be able to define website title for other cultures too. Even the title of added admin menu (Blog, Menu) must be defined for other cultures. |
Don't be confused, there's another type of localization for dynamic data, I already started a PR for that one #4466 |
BTW @ampadashi you could help the community to enhance the RTL by not submitting issues only, you could create a PRs as well 😄 |
It's so great! When are u going to join this PR to master branch? What about the menu item added by Admin Menu module? |
I can't promise coz there 're priorities, but you could help me and start submitting for the once that quite obvious
Could you elaborate? |
Dear @hishamco. I just started studying on the source of OC a month ago. Honestly, I'm wiling to help the community to enhance the RTL. With your help, I will do my best.
When we define items for Admin Menu, We are able to define one Link Text for that item and one Link Text doesn't look so good for using in all cultures. |
Please screen shoot |
It's not the cultures list matter, this need something like content localization /cc @jptissot |
The only issue here is that you need Dynamic Data localization which is something that @hishamco is already working on. (and is blocked waiting for my review) |
Exactly, that's what I point to it above in my comment #4712 (comment) |
closing as it's being tracked by another issue |
When we are creating new content part or content types, there are some fields like Part Title or Hint that can be defined only for one culture. Let's suppose that our website have two cultures. One en-US and the other one fa-IR. If we define content parts and types for en-US first, all the defined fields will be the same for fa-IR culture. So, We will see a lot of English word in Farsi language. I think it would be great if we could define fields unique for all available cultures!
The text was updated successfully, but these errors were encountered: