Skip to content

Fix: Correct timedelta conversion in train-test split. #825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
egordm merged 1 commit into from
Mar 5, 2026
Merged

Fix: Correct timedelta conversion in train-test split. #825

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion openstef/model_selection/model_selection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ def split_data_train_validation_test(
data_.index.unique().sort_values()[1] - data_.index.unique().sort_values()[0]
) # Delta t, assumed to be constant throughout DataFrame
delta = timedelta(
seconds=delta.seconds
seconds=delta.total_seconds()
) # Convert from pandas timedelta to original python timedelta

# Determine which dates are in testset
Expand Down