Skip to content

Fix: Correct timedelta conversion in train-test split.#825

Merged
egordm merged 1 commit intoOpenSTEF:mainfrom
don-alejandrino:fix-train-test-split-timedelta
Mar 5, 2026
Merged

Fix: Correct timedelta conversion in train-test split.#825
egordm merged 1 commit intoOpenSTEF:mainfrom
don-alejandrino:fix-train-test-split-timedelta

Conversation

@don-alejandrino
Copy link
Contributor

This implementation also works when the delta in the data timestamps is >= 1 day.

Fixes #823.

…s when the delta in the data timestamps is >= 1 day.

Signed-off-by: Alexander Geiseler <[email protected]>
@don-alejandrino don-alejandrino requested a review from a team March 5, 2026 12:16
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 5, 2026

Copy link
Collaborator

@egordm egordm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great find.

@egordm egordm merged commit c0fafa3 into OpenSTEF:main Mar 5, 2026
7 checks passed
@egordm
Copy link
Collaborator

egordm commented Mar 5, 2026

Got some issues creating a release. I will let you know once the release is made.

@egordm
Copy link
Collaborator

egordm commented Mar 6, 2026

Release is created at 3.4.93.

@don-alejandrino
Copy link
Contributor Author

That was fast, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Train test split fails when time series data frequency is daily or lower

2 participants