-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: add a modal to manage waypoints in manchette #8796
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #8796 +/- ##
============================================
+ Coverage 39.15% 39.28% +0.13%
- Complexity 2245 2267 +22
============================================
Files 1290 1304 +14
Lines 97316 98618 +1302
Branches 3280 3303 +23
============================================
+ Hits 38100 38744 +644
- Misses 57277 57920 +643
- Partials 1939 1954 +15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
f337268
to
9c45b12
Compare
9c45b12
to
8d1099d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, works well, left two comments
front/src/modules/simulationResult/components/SpaceTimeChart/WaypointsModal.tsx
Outdated
Show resolved
Hide resolved
front/src/modules/simulationResult/components/SpaceTimeChart/WaypointsModal.tsx
Outdated
Show resolved
Hide resolved
2ff39a4
to
262af87
Compare
262af87
to
65f7fd5
Compare
17c9033
to
3a8f5b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, LGTM
front/src/modules/simulationResult/components/SpaceTimeChart/WaypointsModal.tsx
Outdated
Show resolved
Hide resolved
front/src/modules/simulationResult/components/SpaceTimeChart/WaypointsModal.tsx
Outdated
Show resolved
Hide resolved
front/src/modules/simulationResult/components/SpaceTimeChart/WaypointsModal.tsx
Outdated
Show resolved
Hide resolved
front/src/modules/simulationResult/components/SpaceTimeChart/WaypointsModal.tsx
Outdated
Show resolved
Hide resolved
front/src/modules/simulationResult/components/SpaceTimeChart/WaypointsModal.tsx
Outdated
Show resolved
Hide resolved
front/src/modules/simulationResult/components/SpaceTimeChart/ManchetteMenuButton.tsx
Outdated
Show resolved
Hide resolved
.../modules/simulationResult/components/SpaceTimeChart/useGetProjectedTrainOperationalPoints.ts
Outdated
Show resolved
Hide resolved
...ules/simulationResult/components/ManchetteWithSpaceTimeChart/ManchetteWithSpaceTimeChart.tsx
Outdated
Show resolved
Hide resolved
7449215
to
31eca18
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can still find some "waypointsModal" in the code :) in translations and in ManchetteMenuButton :)
front/src/modules/project/helpers/cleanLocalStorageByProject.ts
Outdated
Show resolved
Hide resolved
...ules/simulationResult/components/ManchetteWithSpaceTimeChart/ManchetteWithSpaceTimeChart.tsx
Outdated
Show resolved
Hide resolved
...ules/simulationResult/components/ManchetteWithSpaceTimeChart/ManchetteWithSpaceTimeChart.tsx
Outdated
Show resolved
Hide resolved
front/src/modules/simulationResult/components/SpaceTimeChart/WaypointsPanel.tsx
Outdated
Show resolved
Hide resolved
front/src/modules/simulationResult/components/SpaceTimeChart/WaypointsPanel.tsx
Outdated
Show resolved
Hide resolved
front/src/styles/scss/applications/operationalStudies/_waypointsPanel.scss
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✅
ef98f2d
to
b792268
Compare
Signed-off-by: SharglutDev <[email protected]>
b792268
to
07d0ea7
Compare
Signed-off-by: SharglutDev <[email protected]>
For a brief moment, the computed scales passed to the space time chart can be an empty array. Add a condition to be sure we render the chart only if there at least of scale. Signed-off-by: SharglutDev <[email protected]>
07d0ea7
to
086e108
Compare
close #8627
close #8628
Warning
The shift + click doesn't work with firefox (OpenRailAssociation/osrd-ui#510)
Example of testing :
cancel
and verify that the changes you did have not been saved and that manchette is unaltered