front: fix space time chart scales error

For a brief moment, the computed scales passed to the space time chart can be an empty array. Add a condition to be sure we render the chart only if there at least of scale. Signed-off-by: SharglutDev <[email protected]>
OpenRailAssociation · Oct 15, 2024 · 31eca18 · 31eca18
1 parent b4d2388
commit 31eca18
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 12 deletions.
diff --git a/front/src/applications/operationalStudies/views/SimulationResults.tsx b/front/src/applications/operationalStudies/views/SimulationResults.tsx
@@ -87,6 +87,7 @@ const SimulationResults = ({
     [projectionData]
   );
 
+  // TODO: remove this after closing https://github.com/OpenRailAssociation/osrd-ui/issues/648
   const projectPathTrainResult = useMemo(
     () =>
       projectionData?.projectedTrains.filter((train) => train.space_time_curves.length > 0) || [],

diff --git a/...s/simulationResult/components/ManchetteWithSpaceTimeChart/ManchetteWithSpaceTimeChart.tsx b/...s/simulationResult/components/ManchetteWithSpaceTimeChart/ManchetteWithSpaceTimeChart.tsx
@@ -67,18 +67,24 @@ const ManchetteWithSpaceTimeChartWrapper = ({
             height: `${heightOfManchetteWithSpaceTimeChart - 6}px`,
           }}
         >
-          <SpaceTimeChart
-            className="inset-0 absolute h-full"
-            spaceOrigin={
-              (waypointsPanelData?.filteredWaypoints ?? operationalPoints)[0]?.position || 0
-            }
-            timeOrigin={Math.min(...projectPathTrainResult.map((p) => +new Date(p.departure_time)))}
-            {...spaceTimeChartProps}
-          >
-            {spaceTimeChartProps.paths.map((path) => (
-              <PathLayer key={path.id} path={path} color={path.color} />
-            ))}
-          </SpaceTimeChart>
+          {/* TODO: remove this condition after closing
+          https://github.com/OpenRailAssociation/osrd-ui/issues/648 */}
+          {spaceTimeChartProps.spaceScales.length > 0 && (
+            <SpaceTimeChart
+              className="inset-0 absolute h-full"
+              spaceOrigin={
+                (waypointsPanelData?.filteredWaypoints ?? operationalPoints)[0]?.position || 0
+              }
+              timeOrigin={Math.min(
+                ...projectPathTrainResult.map((p) => +new Date(p.departure_time))
+              )}
+              {...spaceTimeChartProps}
+            >
+              {spaceTimeChartProps.paths.map((path) => (
+                <PathLayer key={path.id} path={path} color={path.color} />
+              ))}
+            </SpaceTimeChart>
+          )}
         </div>
       </div>
     </div>