front: turn on eslint recommended type checked hints #8772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emersion
force-pushed
the
emr/eslint-typed-linting
branch
from
40a425a to
e85e81b
Compare
emersion
added a commit
that referenced
this pull request
Sep 6, 2024
First part of #8772 Enable typed hinting so that ESLint has information about types and can provide more feedback. Only enable a single typed lint rule for now (rest will be a lot more work to fix). The rule @typescript-eslint/no-unnecessary-type-assertion prevents unnecessary type assertions (casting a string to a string). Reducing type assertions is nice because type assertions override type checking and thus may hide type mismatchs.
emersion
added a commit
that referenced
this pull request
Sep 6, 2024
First part of #8772 Enable typed hinting so that ESLint has information about types and can provide more feedback. Only enable a single typed lint rule for now (rest will be a lot more work to fix). The rule @typescript-eslint/no-unnecessary-type-assertion prevents unnecessary type assertions (casting a string to a string). Reducing type assertions is nice because type assertions override type checking and thus may hide type mismatches.
emersion
added a commit
that referenced
this pull request
Sep 10, 2024
First part of #8772 Enable typed hinting so that ESLint has information about types and can provide more feedback. Only enable a single typed lint rule for now (rest will be a lot more work to fix). The rule @typescript-eslint/no-unnecessary-type-assertion prevents unnecessary type assertions (casting a string to a string). Reducing type assertions is nice because type assertions override type checking and thus may hide type mismatches.
emersion
added a commit
that referenced
this pull request
Sep 10, 2024
First part of #8772 Enable typed hinting so that ESLint has information about types and can provide more feedback. Only enable a single typed lint rule for now (rest will be a lot more work to fix). The rule @typescript-eslint/no-unnecessary-type-assertion prevents unnecessary type assertions (casting a string to a string). Reducing type assertions is nice because type assertions override type checking and thus may hide type mismatches. Signed-off-by: Simon Ser <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 10, 2024
First part of #8772 Enable typed hinting so that ESLint has information about types and can provide more feedback. Only enable a single typed lint rule for now (rest will be a lot more work to fix). The rule @typescript-eslint/no-unnecessary-type-assertion prevents unnecessary type assertions (casting a string to a string). Reducing type assertions is nice because type assertions override type checking and thus may hide type mismatches. Signed-off-by: Simon Ser <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 10, 2024
First part of #8772 Enable typed hinting so that ESLint has information about types and can provide more feedback. Only enable a single typed lint rule for now (rest will be a lot more work to fix). The rule @typescript-eslint/no-unnecessary-type-assertion prevents unnecessary type assertions (casting a string to a string). Reducing type assertions is nice because type assertions override type checking and thus may hide type mismatches. Signed-off-by: Simon Ser <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 10, 2024
First part of #8772 Enable typed hinting so that ESLint has information about types and can provide more feedback. Only enable a single typed lint rule for now (rest will be a lot more work to fix). The rule @typescript-eslint/no-unnecessary-type-assertion prevents unnecessary type assertions (casting a string to a string). Reducing type assertions is nice because type assertions override type checking and thus may hide type mismatches. Signed-off-by: Simon Ser <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 10, 2024
First part of #8772 Enable typed hinting so that ESLint has information about types and can provide more feedback. Only enable a single typed lint rule for now (rest will be a lot more work to fix). The rule @typescript-eslint/no-unnecessary-type-assertion prevents unnecessary type assertions (casting a string to a string). Reducing type assertions is nice because type assertions override type checking and thus may hide type mismatches. Signed-off-by: Simon Ser <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 10, 2024
First part of #8772 Enable typed hinting so that ESLint has information about types and can provide more feedback. Only enable a single typed lint rule for now (rest will be a lot more work to fix). The rule @typescript-eslint/no-unnecessary-type-assertion prevents unnecessary type assertions (casting a string to a string). Reducing type assertions is nice because type assertions override type checking and thus may hide type mismatches. Signed-off-by: Simon Ser <[email protected]>
emersion
force-pushed
the
emr/eslint-typed-linting
branch
from
e85e81b to
7c13bfd
Compare
emersion
changed the title
emersion
force-pushed
the
emr/eslint-typed-linting
branch
from
7c13bfd to
f3a2ff0
Compare
emersion
added a commit
that referenced
this pull request
Sep 16, 2024
emersion
added a commit
that referenced
this pull request
Sep 17, 2024
emersion
added a commit
that referenced
this pull request
Sep 17, 2024
emersion
added a commit
that referenced
this pull request
Sep 19, 2024
Part of #8772 See https://typescript-eslint.io/rules/no-unsafe-call/ Signed-off-by: Simon Ser <[email protected]>
emersion
added a commit
that referenced
this pull request
Sep 19, 2024
Part of #8772 See https://typescript-eslint.io/rules/no-unsafe-call/ Signed-off-by: Simon Ser <[email protected]>
emersion
added a commit
that referenced
this pull request
Sep 24, 2024
Part of #8772 See https://typescript-eslint.io/rules/no-unsafe-call/ Signed-off-by: Simon Ser <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 24, 2024
Part of #8772 See https://typescript-eslint.io/rules/no-unsafe-call/ Signed-off-by: Simon Ser <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 24, 2024
Part of #8772 See https://typescript-eslint.io/rules/no-unsafe-call/ Signed-off-by: Simon Ser <[email protected]>
EthanPERRUZZA
pushed a commit
that referenced
this pull request
Sep 25, 2024
EthanPERRUZZA
pushed a commit
that referenced
this pull request
Sep 25, 2024
Part of #8772 See https://typescript-eslint.io/rules/no-unsafe-call/ Signed-off-by: Simon Ser <[email protected]>
emersion
force-pushed
the
emr/eslint-typed-linting
branch
from
f3a2ff0 to
6cc5e98
Compare
See https://typescript-eslint.io/getting-started/typed-linting/ Signed-off-by: Simon Ser <[email protected]>
emersion
force-pushed
the
emr/eslint-typed-linting
branch
from
6cc5e98 to
e482111
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://typescript-eslint.io/getting-started/typed-linting/
no-unsafe-return(front: enable @typescript-eslint/no-unsafe-return #8884)no-unsafe-member-access(43 errors)no-unsafe-argument(front: turn on @typescript-eslint/no-unsafe-argument #10234)no-unsafe-assignment(71 errors)no-unsafe-call(3 errors, front: turn on @typescript-eslint/no-unsafe-call lint #8923)no-misused-promisesno-floating-promisesrestrict-template-expressionsonly-throw-errorrequire-await