front: turn on @typescript-eslint/no-unnecessary-type-assertion lint #8785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emersion
force-pushed
the
emr/unnecessary-type-assertions
branch
from
a71e720 to
ec7fbb6
Compare
kmer2016
reviewed
Sep 6, 2024
Yohh
approved these changes
Sep 6, 2024
emersion
force-pushed
the
emr/unnecessary-type-assertions
branch
2 times, most recently
from
2a0a9b4 to
54752b1
Compare
First part of #8772 Enable typed hinting so that ESLint has information about types and can provide more feedback. Only enable a single typed lint rule for now (rest will be a lot more work to fix). The rule @typescript-eslint/no-unnecessary-type-assertion prevents unnecessary type assertions (casting a string to a string). Reducing type assertions is nice because type assertions override type checking and thus may hide type mismatches. Signed-off-by: Simon Ser <[email protected]>
Generated via eslint --fix, then fixed up two issues in: - src/utils/mapHelper.ts - src/common/Map/WarpedMap/core/projection.ts Signed-off-by: Simon Ser <[email protected]>
emersion
force-pushed
the
emr/unnecessary-type-assertions
branch
from
54752b1 to
8c29554
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First part of #8772
Enable typed hinting so that ESLint has information about types
and can provide more feedback. Only enable a single typed lint
rule for now (rest will be a lot more work to fix).
The rule @typescript-eslint/no-unnecessary-type-assertion prevents
unnecessary type assertions (e.g. casting a string to a string).
Reducing type assertions is nice because type assertions override
type checking and thus may hide type mismatches.