-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: redesign of the list of trains on the results page #8765
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #8765 +/- ##
============================================
+ Coverage 37.07% 37.08% +0.01%
Complexity 2241 2241
============================================
Files 1262 1262
Lines 115972 115925 -47
Branches 3277 3277
============================================
- Hits 42994 42993 -1
+ Misses 71024 70978 -46
Partials 1954 1954
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
c41c644
to
fa398c7
Compare
46341a2
to
a809797
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Great work! Not much to say on the code side, just a small CSS suggestion. However, I have a few questions regarding the behavior:
-
When clicking the checkbox on a TrainCard, the corresponding train gets selected, and the curves and output tables are updated with that train's info. Previously, the train was selected by clicking on the TrainCard itself, not the checkbox.
-
In a new scenario, the 'No train' checkbox is always checked and cannot be unchecked.
-
There's no longer any distinction for trains on which path projection has been performed.
-
The hover effect on the first action button doesn't turn white like the others."
front/src/styles/scss/applications/operationalStudies/_scenario.scss
Outdated
Show resolved
Hide resolved
front/src/modules/trainschedule/components/Timetable/TimetableTrainCard.tsx
Outdated
Show resolved
Hide resolved
d1455b3
to
d5470a3
Compare
f5774ac
to
9170295
Compare
front/src/modules/trainschedule/components/Timetable/TimetableToolbar.tsx
Outdated
Show resolved
Hide resolved
front/src/modules/trainschedule/components/Timetable/TimetableTrainCard.tsx
Outdated
Show resolved
Hide resolved
front/src/styles/scss/applications/operationalStudies/_scenario.scss
Outdated
Show resolved
Hide resolved
front/src/modules/trainschedule/components/Timetable/TimetableTrainCard.tsx
Show resolved
Hide resolved
front/src/modules/trainschedule/components/Timetable/TimetableTrainCard.tsx
Outdated
Show resolved
Hide resolved
146fa72
to
cda9251
Compare
0415fbc
to
040431f
Compare
front/src/modules/trainschedule/components/Timetable/TimetableTrainCard.tsx
Outdated
Show resolved
Hide resolved
front/src/modules/trainschedule/components/Timetable/TimetableToolbar.tsx
Outdated
Show resolved
Hide resolved
front/src/modules/trainschedule/components/Timetable/TimetableToolbar.tsx
Outdated
Show resolved
Hide resolved
front/src/modules/trainschedule/components/Timetable/TimetableToolbar.tsx
Outdated
Show resolved
Hide resolved
front/src/styles/scss/applications/operationalStudies/_scenario.scss
Outdated
Show resolved
Hide resolved
front/src/styles/scss/applications/operationalStudies/_scenario.scss
Outdated
Show resolved
Hide resolved
front/src/styles/scss/applications/operationalStudies/_scenario.scss
Outdated
Show resolved
Hide resolved
front/src/styles/scss/applications/operationalStudies/_scenario.scss
Outdated
Show resolved
Hide resolved
front/src/styles/scss/applications/operationalStudies/_scenario.scss
Outdated
Show resolved
Hide resolved
9030df8
to
7712334
Compare
7b61cf2
to
7fb594f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm and tested, great job :) Thank you @emersion for participating as well !
Co-authored-by: Simon Ser <[email protected]> Signed-off-by: theocrsb <[email protected]> Signed-off-by: Simon Ser <[email protected]>
Co-authored-by: Simon Ser <[email protected]> Signed-off-by: theocrsb <[email protected]> Signed-off-by: Simon Ser <[email protected]>
The collapsed timetable header has a background which doesn't match the rest of the app. Signed-off-by: Simon Ser <[email protected]>
49de844
to
c3fab23
Compare
Mockup: https://www.sketch.com/s/2fb064cd-c483-46ac-bd30-72705fd63e75/a/el9lZmq
Closes #8601