Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: redesign of the list of trains on the results page #8765

Merged
merged 3 commits into from
Sep 26, 2024

Conversation

theocrsb
Copy link
Contributor

@theocrsb theocrsb commented Sep 5, 2024

@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 324 lines in your changes missing coverage. Please review.

Project coverage is 37.08%. Comparing base (a5e9ca2) to head (c3fab23).
Report is 4 commits behind head on dev.

Files with missing lines Patch % Lines
...hedule/components/Timetable/TimetableTrainCard.tsx 0.00% 117 Missing ⚠️
...schedule/components/Timetable/TimetableToolbar.tsx 0.00% 105 Missing ⚠️
...trainschedule/components/Timetable/FilterPanel.tsx 0.00% 69 Missing and 1 partial ⚠️
...s/trainschedule/components/Timetable/Timetable.tsx 0.00% 30 Missing and 1 partial ⚠️
...tudies/components/Scenario/ScenarioDescription.tsx 0.00% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #8765      +/-   ##
============================================
+ Coverage     37.07%   37.08%   +0.01%     
  Complexity     2241     2241              
============================================
  Files          1262     1262              
  Lines        115972   115925      -47     
  Branches       3277     3277              
============================================
- Hits          42994    42993       -1     
+ Misses        71024    70978      -46     
  Partials       1954     1954              
Flag Coverage Δ
core 74.79% <ø> (ø)
editoast 72.38% <ø> (-0.01%) ⬇️
front 15.17% <0.00%> (+0.01%) ⬆️
gateway 2.22% <ø> (ø)
osrdyne 2.57% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@theocrsb theocrsb force-pushed the tce/front/trainschedule/redign-list-trains branch 18 times, most recently from c41c644 to fa398c7 Compare September 12, 2024 09:01
@theocrsb theocrsb marked this pull request as ready for review September 12, 2024 09:04
@theocrsb theocrsb requested a review from a team as a code owner September 12, 2024 09:04
@emersion emersion self-assigned this Sep 12, 2024
@theocrsb
Copy link
Contributor Author

@theocrsb theocrsb force-pushed the tce/front/trainschedule/redign-list-trains branch 2 times, most recently from 46341a2 to a809797 Compare September 13, 2024 07:03
Copy link
Contributor

@kmer2016 kmer2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Great work! Not much to say on the code side, just a small CSS suggestion. However, I have a few questions regarding the behavior:

  • It seems like a third scrollbar has appeared.
    image

  • When clicking the checkbox on a TrainCard, the corresponding train gets selected, and the curves and output tables are updated with that train's info. Previously, the train was selected by clicking on the TrainCard itself, not the checkbox.

  • In a new scenario, the 'No train' checkbox is always checked and cannot be unchecked.

  • There's no longer any distinction for trains on which path projection has been performed.

  • The hover effect on the first action button doesn't turn white like the others."

@theocrsb theocrsb force-pushed the tce/front/trainschedule/redign-list-trains branch 2 times, most recently from d1455b3 to d5470a3 Compare September 24, 2024 14:18
@theocrsb theocrsb force-pushed the tce/front/trainschedule/redign-list-trains branch from f5774ac to 9170295 Compare September 24, 2024 14:27
@theocrsb theocrsb force-pushed the tce/front/trainschedule/redign-list-trains branch from 146fa72 to cda9251 Compare September 24, 2024 15:33
@theocrsb theocrsb force-pushed the tce/front/trainschedule/redign-list-trains branch 2 times, most recently from 0415fbc to 040431f Compare September 25, 2024 08:46
@theocrsb theocrsb force-pushed the tce/front/trainschedule/redign-list-trains branch 4 times, most recently from 9030df8 to 7712334 Compare September 26, 2024 14:08
@SharglutDev SharglutDev removed the request for review from a team September 26, 2024 14:15
@theocrsb theocrsb force-pushed the tce/front/trainschedule/redign-list-trains branch 3 times, most recently from 7b61cf2 to 7fb594f Compare September 26, 2024 14:35
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested, great job :) Thank you @emersion for participating as well !

theocrsb and others added 3 commits September 26, 2024 17:19
Co-authored-by: Simon Ser <[email protected]>
Signed-off-by: theocrsb <[email protected]>
Signed-off-by: Simon Ser <[email protected]>
Co-authored-by: Simon Ser <[email protected]>
Signed-off-by: theocrsb <[email protected]>
Signed-off-by: Simon Ser <[email protected]>
The collapsed timetable header has a background which doesn't match
the rest of the app.

Signed-off-by: Simon Ser <[email protected]>
@theocrsb theocrsb force-pushed the tce/front/trainschedule/redign-list-trains branch from 49de844 to c3fab23 Compare September 26, 2024 15:19
@theocrsb theocrsb added this pull request to the merge queue Sep 26, 2024
Merged via the queue into dev with commit 139d681 Sep 26, 2024
23 checks passed
@theocrsb theocrsb deleted the tce/front/trainschedule/redign-list-trains branch September 26, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redesign of the list of trains on the results page
7 participants