Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: redesigned top of scenario page #8861

Merged
merged 1 commit into from
Oct 3, 2024
Merged

front: redesigned top of scenario page #8861

merged 1 commit into from
Oct 3, 2024

Conversation

theocrsb
Copy link
Contributor

@theocrsb theocrsb commented Sep 13, 2024 •
edited by Castavo
Loading

this PR cannot be merged before this PR

closes https://github.com/osrd-project/osrd-confidential/issues/667

@theocrsb theocrsb requested a review from a team as a code owner September 13, 2024 08:31
@theocrsb theocrsb force-pushed the tce/front/trainschedule/redign-top-scenario-page branch from 9e152b5 to 0eba688 Compare September 13, 2024 08:32
@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2024 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 71 lines in your changes missing coverage. Please review.

Project coverage is 37.22%. Comparing base (665c62d) to head (d37c261).
Report is 5 commits behind head on dev.

Files with missing lines Patch % Lines
...tudies/components/Scenario/ScenarioDescription.tsx 0.00% 44 Missing and 1 partial ⚠️
...operationalStudies/components/MicroMacroSwitch.tsx 0.00% 18 Missing ⚠️
...s/trainschedule/components/Timetable/Timetable.tsx 0.00% 7 Missing ⚠️
...lStudies/components/Scenario/InfraLoadingState.tsx 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@             Coverage Diff              @@
##                dev    #8861      +/-   ##
============================================
- Coverage     37.22%   37.22%   -0.01%     
  Complexity     2242     2242              
============================================
  Files          1265     1265              
  Lines        116360   116355       -5     
  Branches       3280     3280              
============================================
- Hits          43318    43315       -3     
+ Misses        71087    71085       -2     
  Partials       1955     1955
Flag Coverage Δ
core 74.78% <ø> (ø)
editoast 72.09% <ø> (-0.02%) ⬇️
front 15.33% <0.00%> (+<0.01%) ⬆️
gateway 2.22% <ø> (ø)
osrdyne 2.56% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@theocrsb theocrsb changed the title Tce/front/trainschedule/redign top scenario page Redesigned top of description page Sep 13, 2024
@theocrsb theocrsb changed the title Redesigned top of description page front: redesigned top of description page Sep 13, 2024
@theocrsb theocrsb changed the title front: redesigned top of description page front: redesigned top of scenario page Sep 13, 2024
Uriel-Sautron
Uriel-Sautron approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@Uriel-Sautron Uriel-Sautron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!! Good work, just one last comment for me.

front/src/styles/scss/applications/operationalStudies/_scenario.scss Outdated Show resolved Hide resolved
@theocrsb theocrsb force-pushed the tce/front/trainschedule/redign-top-scenario-page branch 5 times, most recently from bf14715 to f61ba6e Compare September 25, 2024 08:15
@theocrsb theocrsb force-pushed the tce/front/trainschedule/redign-top-scenario-page branch 2 times, most recently from 5630dc3 to 26c04f3 Compare September 30, 2024 08:07
@emersion emersion removed their assignment Sep 30, 2024
SharglutDev
SharglutDev reviewed Sep 30, 2024
View reviewed changes
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, left some comments

front/tests/pages/scenario-page-model.ts Show resolved Hide resolved
front/src/styles/scss/applications/operationalStudies/_scenario.scss Outdated Show resolved Hide resolved
front/src/styles/scss/applications/operationalStudies/_scenario.scss Show resolved Hide resolved
front/src/styles/scss/applications/operationalStudies/_scenario.scss Outdated Show resolved Hide resolved
front/src/styles/scss/applications/operationalStudies/_scenario.scss Outdated Show resolved Hide resolved
front/src/styles/scss/applications/operationalStudies/_scenario.scss Show resolved Hide resolved
front/src/styles/scss/applications/operationalStudies/_scenario.scss Outdated Show resolved Hide resolved
front/src/styles/scss/applications/operationalStudies/_scenario.scss Outdated Show resolved Hide resolved
front/src/styles/scss/applications/operationalStudies/_scenario.scss Outdated Show resolved Hide resolved
front/src/applications/operationalStudies/components/Scenario/ScenarioDescription.tsx Outdated Show resolved Hide resolved
SharglutDev
SharglutDev reviewed Oct 1, 2024
View reviewed changes
front/src/styles/scss/applications/operationalStudies/_scenario.scss Outdated Show resolved Hide resolved
front/src/applications/operationalStudies/components/MicroMacroSwitch.tsx Outdated Show resolved Hide resolved
front/src/styles/scss/applications/operationalStudies/_scenario.scss Outdated Show resolved Hide resolved
front/src/styles/scss/applications/operationalStudies/_scenario.scss Outdated Show resolved Hide resolved
front/src/styles/scss/applications/operationalStudies/_scenario.scss Outdated Show resolved Hide resolved
front/src/styles/scss/applications/operationalStudies/_scenario.scss Outdated Show resolved Hide resolved
front/src/styles/scss/applications/operationalStudies/_scenario.scss Outdated Show resolved Hide resolved
front/src/styles/scss/applications/operationalStudies/_scenario.scss Outdated Show resolved Hide resolved
front/src/styles/scss/applications/operationalStudies/_scenario.scss Outdated Show resolved Hide resolved
@theocrsb theocrsb requested a review from SharglutDev October 2, 2024 12:11
@theocrsb theocrsb force-pushed the tce/front/trainschedule/redign-top-scenario-page branch from 7c3bc2d to fae989f Compare October 2, 2024 14:37
@theocrsb theocrsb force-pushed the tce/front/trainschedule/redign-top-scenario-page branch from 400cb84 to f6c7721 Compare October 2, 2024 15:05
@theocrsb theocrsb requested a review from SharglutDev October 3, 2024 07:43
@theocrsb theocrsb force-pushed the tce/front/trainschedule/redign-top-scenario-page branch from 5e0ad0c to 7123ab0 Compare October 3, 2024 08:28
@theocrsb theocrsb force-pushed the tce/front/trainschedule/redign-top-scenario-page branch from 7123ab0 to d37c261 Compare October 3, 2024 08:32
SharglutDev
SharglutDev approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested, great job

@theocrsb theocrsb enabled auto-merge October 3, 2024 08:34
@theocrsb theocrsb added this pull request to the merge queue Oct 3, 2024
Merged via the queue into dev with commit f25a37b Oct 3, 2024
24 checks passed
@theocrsb theocrsb deleted the tce/front/trainschedule/redign-top-scenario-page branch October 3, 2024 09:12
@Synar Synar mentioned this pull request Nov 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thibautsailly thibautsailly thibautsailly left review comments

@SharglutDev SharglutDev SharglutDev approved these changes

@Uriel-Sautron Uriel-Sautron Uriel-Sautron approved these changes

Assignees

@theocrsb theocrsb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@theocrsb @codecov-commenter @thibautsailly @Uriel-Sautron @SharglutDev @emersion