Implements world.address & friends, adds remaining opendream_unimplemented world vars/procs #774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fairly certain the engine switch predates |
wixoaGit
requested changes
Sep 4, 2022
Altoids1
force-pushed
the
around-the-world
branch
from
cd0f83e to
82454a2
Compare
Altoids1
force-pushed
the
around-the-world
branch
from
82454a2 to
50f557f
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Altoids1
force-pushed
the
around-the-world
branch
from
50f557f to
0a1735c
Compare
Altoids1
force-pushed
the
around-the-world
branch
from
0a1735c to
707c9c1
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
world.address world.port world.url world.internet_address EDIT: Does some various tweaking as per Wixoa's review
This should improve compile-ability, especially movement_mode. EDIT: MOVEMENT_MODE macros now start at 0 instead of 1, as per parity EDIT: Forgot to add cache_lifespan, lol EDIT: Removing cache_lifespan since it now exists on master apparently
Altoids1
force-pushed
the
around-the-world
branch
from
707c9c1 to
b28faed
Compare
wixoaGit
requested changes
Oct 26, 2022
EDIT: also does Wixoa's new review
Altoids1
force-pushed
the
around-the-world
branch
from
1a1cf8d to
9d31a82
Compare
wixoaGit
approved these changes
Oct 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
world.address and world.port are implemented, after a regression during RobustToolbox porting last year caused them to become commented out.
Makes #735 at least compile by setting up the associated
opendream_unimplemented. Also went ahead and added every other one I could find in the ref; yell if I missed any.Fixes #804.
Changelog