Dials PR back a bit, TODO'd internet_address & url

EDIT: also does Wixoa's new review
OpenDreamProject · Oct 26, 2022 · 9d31a82 · 9d31a82
1 parent b28faed
commit 9d31a82
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 12 deletions.
diff --git a/DMCompiler/DMStandard/Types/World.dm b/DMCompiler/DMStandard/Types/World.dm
@@ -31,9 +31,9 @@
 	var/version = 0 as opendream_unimplemented
 
 	var/address
-	var/port = 0
-	var/internet_address = "127.0.0.1"
-	var/url
+	var/port = 0 as opendream_compiletimereadonly
+	var/internet_address = "127.0.0.1" as opendream_unimplemented
+	var/url as opendream_unimplemented
 	var/visibility = 0 as opendream_unimplemented
 	var/status as opendream_unimplemented
 	var/list/params = list() as opendream_unimplemented

diff --git a/OpenDreamRuntime/IDreamManager.cs b/OpenDreamRuntime/IDreamManager.cs
@@ -1,6 +1,3 @@
-using System.Linq;
-using System.Threading.Tasks;
-using System.Net;
 using OpenDreamRuntime.Objects;
 using Robust.Server.Player;
 

diff --git a/OpenDreamRuntime/Objects/MetaObjects/DreamMetaObjectWorld.cs b/OpenDreamRuntime/Objects/MetaObjects/DreamMetaObjectWorld.cs
@@ -49,12 +49,7 @@ private IPAddress? InternetAddress
         {
             get
             {
-                NetManager? net = (NetManager?)_netManager;
-                if(net == null) // This may be the case if we're on IntegrationNetManager instead of NetManager.
-                { // If so, I don't really know how to force RT to fess up about what our IP is, since it's all hidden behind privates at time of writing.
-                    return null;
-                }
-                return net.ServerChannel?.RemoteEndPoint.Address;
+                return null; //TODO: Implement this!
             }
         }