Skip to content

fix(runtime): verify required artifact readability #3941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BunsDev merged 1 commit into from
Jul 27, 2026
Merged

fix(runtime): verify required artifact readability #3941

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions src/lib/runtime-availability.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,9 +204,24 @@ try {
env: { Path: "C:\\bin" },
platform: "win32",
statFile: (candidate) => candidate === "C:\\bin\\node.exe" || candidate === "C:\\bin\\copilot-entry.js",
readableFile: (candidate) => candidate === "C:\\bin\\copilot-entry.js",
});
assert.equal(requiredArtifactReady.state, "ready", "a complete direct launch plan is ready");

const statOnlyArtifact = evaluateRuntimeAvailability({
runner: "copilot",
command: "node.exe",
requiredFiles: [path.join(scratch, "missing-required-artifact.js")],
env: { Path: "C:\\bin" },
platform: "win32",
statFile: () => true,
});
assert.equal(
statOnlyArtifact.state,
"unlaunchable",
"a command stat double cannot silently stand in for required-artifact readability",
);

const requiredArtifactUnreadable = evaluateRuntimeAvailability({
runner: "copilot",
command: "node.exe",
Expand Down Expand Up @@ -422,6 +437,7 @@ try {
platform: "win32",
requiredFiles: [openCodeTarget],
statFile: winStats([nodeHost, openCodeTarget]),
readableFile: winStats([openCodeTarget]),
});
assert.equal(
openCodeWinReady.state,
Expand All @@ -436,6 +452,7 @@ try {
platform: "win32",
requiredFiles: [openCodeTarget],
statFile: winStats([nodeHost]),
readableFile: winStats([]),
});
assert.equal(
openCodeTargetGone.state,
Expand Down
3 changes: 1 addition & 2 deletions src/lib/runtime-availability.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,8 +411,7 @@ export function evaluateRuntimeAvailability(
const inspectCandidate: InspectCandidateFn = probe.statFile
? (candidate) => inspectWithStatFile(candidate, probe.statFile!)
: (candidate) => defaultInspectCandidate(candidate, platform);
const readableFile = probe.readableFile
?? (probe.statFile ? probe.statFile : defaultReadableFile);
const readableFile = probe.readableFile ?? defaultReadableFile;
const label = RUNNER_LABELS[runner];
try {
if (probe.resolutionFailed) {
Expand Down
Loading