fix(runtime): verify required artifact readability - #3941
Merged
Conversation
BunsDev
force-pushed
the
fix/runtime-required-file-readability-3927
branch
from
July 26, 2026 23:44
0497b43 to
f700106
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Tightens evaluateRuntimeAvailability() preflight semantics so required launch artifacts are verified using a real readability check by default (rather than allowing a command statFile test double to silently satisfy artifact checks), and adds regression tests for the behavior discovered post-merge in #3927.
Changes:
- Remove the implicit fallback that reused
statFileas the required-artifact readability check; required artifacts now default todefaultReadableFile. - Extend Windows shim/direct-launch coverage to ensure a
statFiledouble can’t mask missing/unreadable required artifacts. - Add OpenCode Windows required-artifact readiness coverage using an explicit
readableFiledouble.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/lib/runtime-availability.ts | Ensures required-artifact verification uses defaultReadableFile unless an explicit readableFile probe is provided. |
| src/lib/runtime-availability.test.ts | Adds regression tests covering required-artifact readability (including OpenCode Windows scenarios). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
BunsDev
force-pushed
the
fix/runtime-required-file-readability-3927
branch
from
July 26, 2026 23:47
f700106 to
3f0292a
Compare
BunsDev
force-pushed
the
fix/runtime-required-file-readability-3927
branch
from
July 27, 2026 00:08
3f0292a to
592df54
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
statFilefallbackruntime-availability.test.tspasses on currentorigin/mainpnpm typecheckpnpm lintpnpm check:tests-wired— 1,274 files wired, 1 allowlistedgit diff --check origin/main...HEADpnpm test:api— 279/279 files passed before the overlapping Hermes fix(chat): preflight Hermes direct launch safely #3911 base advance; on exact current base, the suite reaches an existingroute-hermes-availability.integration.test.tsfailure (runtime_process_failedvsruntime_missing) that reproduces identically on a clean detachedorigin/maincheckout at25d817c0bFollow-up to #3927.