Skip to content

fix(chat): preflight Hermes direct launch safely#3911

Merged
CompleteDotTech merged 35 commits into
mainfrom
codex/issue-3860-hermes-launch
Jul 26, 2026
Merged

fix(chat): preflight Hermes direct launch safely#3911
CompleteDotTech merged 35 commits into
mainfrom
codex/issue-3860-hermes-launch

Conversation

@CompleteDotTech

@CompleteDotTech CompleteDotTech commented Jul 26, 2026

Copy link
Copy Markdown
Member

Fixes #3860## What changed- Resolves each direct Hermes CLI launch through one native plan: hermes.exe on Windows and hermes elsewhere, retaining the exact resolved command, familiar-scoped environment, and child working directory.- Uses the plan for direct-chat preflight, hermes chat --help model probing, spawn, and harness status/version reporting; unready Hermes status never falls back to which/where discovery. Windows .cmd/.bat shim-only installs are unlaunchable, never ready.- Keeps model probing optional: failed or unsupported help only suppresses --model; it does not make a launchable Hermes unavailable.- Emits structured, path-safe runtime errors for unavailable launches and started process/auth/config failures. Failed Hermes stdout and session ids are withheld until a zero exit, so failures cannot fabricate assistant text, session stubs, or persistence.- Retries a stale Hermes native session without --resume without emitting a terminal process failure, leaking stale output/session ids, or suppressing the successful retry's persistence.- Preserves Hermes API mode, SSH routing, and other harness launch contracts.## ValidationPassed on c3c4b900 (merged origin/main af95b0bc):- Hermes runtime availability, direct-chat availability integration (including stale-session retry), model routing/capabilities, harness status, adapter merge, Familiar Studio, and API contract tests- pnpm check:tests-wired- pnpm lint- pnpm typecheck- git diff --check origin/main...HEADBroader-suite note: local pnpm test:api reached scripts/dev-app-teardown.test.mjs after three passing files, then reproduced its pre-existing native-Windows fake-server bind timeout (port 61865). Hermes tests were run directly and pass; this environmental failure was not masked.## CIA fresh CI run is queued for c3c4b900; the PR remains draft. There are no review comments, reviews, or unresolved actionable threads.

@CompleteDotTech CompleteDotTech self-assigned this Jul 26, 2026
# Conflicts:
#	src/app/api/chat/send/route.ts
@CompleteDotTech
CompleteDotTech marked this pull request as ready for review July 26, 2026 23:55
@CompleteDotTech
CompleteDotTech merged commit 25d817c into main Jul 26, 2026
15 checks passed
@CompleteDotTech
CompleteDotTech deleted the codex/issue-3860-hermes-launch branch July 26, 2026 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hermes: preflight direct executable resolution and preserve Windows launch safety

1 participant