mpicpp-lite separation #831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- mpicpp-lite is now treated as a regular dependency - OpenSn behaves more as a library, i.e. does not come with bundled dependecies - this helps applications depending on OpenSn not to re-package mpicpp-lite and just use ti via `find_package`
Collaborator
Author
|
This will fail, because it probably needs an update on the CI machine. |
Collaborator
Author
|
I converted this into a draft and marked this as suggestion... This will need some more testing than on my machine locally... |
Collaborator
|
I've updated the dependency installs on the CI machine and kicked off the regression and clang-tidy jobs on this PR. |
wdhawkins
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate mpicpp-lite into a standalone dependency, i.e. treated it like other dependencies.
mpicpp-litefind_packageit,mpicpp-liteis automatically checked formpicpp-liteis publicly linked, it is automatically added into application targets withtarget_link_libraries(... PUBLIC opensn::libopensn)Supports Open-Sn/OpenSnApp#3