Skip to content

Conversation

@quincy-huhn98
Copy link

I've submitted as draft to get feedback on the code as well as help with the CMake and workflows.

As is right now the CMake works for me but my attempts to remove the hardcoded paths for OpenSn have not worked.

The workflows I have not modified since I wrote them for the initial test app.

@wdhawkins
Copy link

@quincy-huhn98 Interfacing your application with the latest version of OpenSn develop should be much easier now. For application support, you'll want to do an out-of-build install of OpenSn. When compiling OpenSn, do the following:

cmake -DCMAKE_INSTALL_PREFIX=/path/to/opensn/install .. && make -j && make install

This will create the directory /path/to/opensn/install that has the typical lib, include, bin structure. Add that directory to your CMAKE_INSTALL_PREFIX or, optionally, set OpenSn_DIR to that directory.

With these changes, find_package(OpenSn) in your application's CMakeLists.txt will work correctly. Your CMakeLists.txt can also be simplified. Here is a revised version: CMakeLists.txt

Let me know if you have any problems.

@quincy-huhn98
Copy link
Author

quincy-huhn98 commented Nov 13, 2025

@wdhawkins thank you for the updated CMake. I made all the changes except removing opensn::libopensnpy as my ROMApp inherits from opensnpy::PyApp.

@quincy-huhn98 quincy-huhn98 marked this pull request as ready for review December 2, 2025 23:40
Copy link

@andrsd andrsd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename these files to match the coding standard:

  • ROM_problem.h -> rom_problem.h
  • ROM_problem.cc -> rom_problem.cc
  • ROM_structs.h -> rom_structs.h

@quincy-huhn98
Copy link
Author

I have updated the names

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants