Db pagination for tabular reviews

backend/migrations/20260726_01_tabular_reviews_pagination.sql

@@ -0,0 +1,216 @@
+-- Migration date: 2026-07-26
+
+-- Performance pass on get_tabular_reviews_overview:
+-- 1. Compute document_count once (previously recomputed in the select list and
+--    twice more in the `documents` sort case branches) and reuse the value.
+-- 2. Narrow cell_document_counts to only the reviews that will actually use it
+--    (document_ids is not a jsonb array), instead of aggregating tabular_cells
+--    for every visible review regardless of whether the result gets used.
+-- 3. Add a trigram index so the leading-wildcard title search can use an index
+--    instead of a full scan of the pre-filtered set.
+
+create extension if not exists pg_trgm;
+
+create index if not exists tabular_reviews_title_trgm_idx
+  on public.tabular_reviews using gin (lower(title) gin_trgm_ops);
+
+-- Remove the earlier paginated signature if this migration was tested before
+-- scope filtering was added. The legacy three-argument signature is retained
+-- below as a non-ambiguous compatibility wrapper.
+drop function if exists public.get_tabular_reviews_overview(
+  text, text, text, integer, integer, text, text, text
+);
+
+create or replace function public.get_tabular_reviews_overview(
+  p_user_id text,
+  p_user_email text,
+  p_project_id text,
+  p_scope text,
+  p_limit integer,
+  p_offset integer,
+  p_search_term text,
+  p_sort_key text,
+  p_sort_direction text
+)
+returns table (
+  id uuid,
+  project_id uuid,
+  user_id text,
+  title text,
+  columns_config jsonb,
+  document_ids jsonb,
+  workflow_id uuid,
+  shared_with jsonb,
+  created_at timestamptz,
+  updated_at timestamptz,
+  is_owner boolean,
+  document_count integer
+)
+language sql
+stable
+as $$
+  with accessible_projects as (
+    select p.id
+    from public.projects p
+    where p.user_id = p_user_id
+       or (
+        coalesce(p_user_email, '') <> ''
+        and p.user_id <> p_user_id
+        and p.shared_with @> jsonb_build_array(p_user_email)
+      )
+  ),
+  visible_reviews as (
+    select tr.*
+    from public.tabular_reviews tr
+    where (p_project_id is null or tr.project_id::text = p_project_id)
+      and (
+        coalesce(p_scope, 'all') = 'all'
+        or (p_scope = 'in-project' and tr.project_id is not null)
+        or (p_scope = 'standalone' and tr.project_id is null)
+      )
+      and (
+        p_search_term is null
+        or p_search_term = ''
+        or lower(tr.title) like '%' || lower(p_search_term) || '%'
+      )
+      and (
+        p_project_id is null
+        or exists (
+          select 1
+          from accessible_projects ap
+          where ap.id::text = p_project_id
+        )
+      )
+      and (
+        tr.user_id = p_user_id
+        or (
+          tr.project_id in (select ap.id from accessible_projects ap)
+          and tr.user_id <> p_user_id
+        )
+        or (
+          p_project_id is null
+          and coalesce(p_user_email, '') <> ''
+          and tr.user_id <> p_user_id
+          and tr.shared_with @> jsonb_build_array(p_user_email)
+        )
+      )
+  ),
+  cell_document_counts as (
+    select
+      tc.review_id,
+      count(distinct tc.document_id)::integer as document_count
+    from public.tabular_cells tc
+    where tc.review_id in (
+      select vr.id
+      from visible_reviews vr
+      where jsonb_typeof(vr.document_ids) is distinct from 'array'
+    )
+    group by tc.review_id
+  ),
+  review_document_counts as (
+    select
+      vr.id,
+      case
+        when jsonb_typeof(vr.document_ids) = 'array'
+          then (
+            select count(distinct doc_id.value)::integer
+            from jsonb_array_elements_text(vr.document_ids) as doc_id(value)
+          )
+        else coalesce(cdc.document_count, 0)
+      end as document_count
+    from visible_reviews vr
+    left join cell_document_counts cdc
+      on cdc.review_id = vr.id
+  )
+  select
+    vr.id,
+    vr.project_id,
+    vr.user_id,
+    vr.title,
+    vr.columns_config,
+    vr.document_ids,
+    vr.workflow_id,
+    vr.shared_with,
+    vr.created_at,
+    vr.updated_at,
+    vr.user_id = p_user_id as is_owner,
+    rdc.document_count
+  from visible_reviews vr
+  join review_document_counts rdc
+    on rdc.id = vr.id
+  order by
+    case
+      when p_sort_key = 'name' and p_sort_direction = 'asc' then lower(coalesce(vr.title, ''))
+      else null
+    end asc,
+    case
+      when p_sort_key = 'name' and p_sort_direction = 'desc' then lower(coalesce(vr.title, ''))
+      else null
+    end desc,
+    case
+      when p_sort_key = 'columns' and p_sort_direction = 'asc' then jsonb_array_length(coalesce(vr.columns_config, '[]'::jsonb))
+      else null
+    end asc,
+    case
+      when p_sort_key = 'columns' and p_sort_direction = 'desc' then jsonb_array_length(coalesce(vr.columns_config, '[]'::jsonb))
+      else null
+    end desc,
+    case
+      when p_sort_key = 'documents' and p_sort_direction = 'asc' then rdc.document_count
+      else null
+    end asc,
+    case
+      when p_sort_key = 'documents' and p_sort_direction = 'desc' then rdc.document_count
+      else null
+    end desc,
+    case
+      when p_sort_key = 'created' and p_sort_direction = 'asc' then vr.created_at
+      else null
+    end asc,
+    case
+      when p_sort_key = 'created' and p_sort_direction = 'desc' then vr.created_at
+      else null
+    end desc,
+    vr.created_at desc,
+    vr.id asc
+  limit greatest(coalesce(p_limit, 20), 1)
+  offset greatest(coalesce(p_offset, 0), 0);
+$$;
+
+-- Preserve the pre-pagination RPC contract without making PostgREST choose
+-- between two functions that can both accept the same three arguments.
+create or replace function public.get_tabular_reviews_overview(
+  p_user_id text,
+  p_user_email text default null,
+  p_project_id text default null
+)
+returns table (
+  id uuid,
+  project_id uuid,
+  user_id text,
+  title text,
+  columns_config jsonb,
+  document_ids jsonb,
+  workflow_id uuid,
+  shared_with jsonb,
+  created_at timestamptz,
+  updated_at timestamptz,
+  is_owner boolean,
+  document_count integer
+)
+language sql
+stable
+as $$
+  select *
+  from public.get_tabular_reviews_overview(
+    p_user_id,
+    p_user_email,
+    p_project_id,
+    'all',
+    2147483647,
+    0,
+    null,
+    'created',
+    'desc'
+  );
+$$;

backend/schema.sql

@@ -4,6 +4,7 @@
 -- newer than the version of Mike they currently have deployed.
 
 create extension if not exists "pgcrypto";
+create extension if not exists "pg_trgm";
 
 -- ---------------------------------------------------------------------------
 -- User profiles
@@ -602,6 +603,9 @@ create index if not exists idx_tabular_reviews_project
 create index if not exists tabular_reviews_shared_with_idx
   on public.tabular_reviews using gin (shared_with);
 
+create index if not exists tabular_reviews_title_trgm_idx
+  on public.tabular_reviews using gin (lower(title) gin_trgm_ops);
+
 create or replace function public.get_projects_overview(
   p_user_id text,
   p_user_email text default null
@@ -694,10 +698,20 @@ create table if not exists public.tabular_cells (
 create index if not exists idx_tabular_cells_review
   on public.tabular_cells(review_id, document_id, column_index);
 
+drop function if exists public.get_tabular_reviews_overview(
+  text, text, text, integer, integer, text, text, text
+);
+
 create or replace function public.get_tabular_reviews_overview(
   p_user_id text,
-  p_user_email text default null,
-  p_project_id text default null
+  p_user_email text,
+  p_project_id text,
+  p_scope text,
+  p_limit integer,
+  p_offset integer,
+  p_search_term text,
+  p_sort_key text,
+  p_sort_direction text
 )
 returns table (
   id uuid,
@@ -730,6 +744,16 @@ as $$
     select tr.*
     from public.tabular_reviews tr
     where (p_project_id is null or tr.project_id::text = p_project_id)
+      and (
+        coalesce(p_scope, 'all') = 'all'
+        or (p_scope = 'in-project' and tr.project_id is not null)
+        or (p_scope = 'standalone' and tr.project_id is null)
+      )
+      and (
+        p_search_term is null
+        or p_search_term = ''
+        or lower(tr.title) like '%' || lower(p_search_term) || '%'
+      )
       and (
         p_project_id is null
         or exists (
@@ -757,8 +781,27 @@ as $$
       tc.review_id,
       count(distinct tc.document_id)::integer as document_count
     from public.tabular_cells tc
-    where tc.review_id in (select vr.id from visible_reviews vr)
+    where tc.review_id in (
+      select vr.id
+      from visible_reviews vr
+      where jsonb_typeof(vr.document_ids) is distinct from 'array'
+    )
     group by tc.review_id
+  ),
+  review_document_counts as (
+    select
+      vr.id,
+      case
+        when jsonb_typeof(vr.document_ids) = 'array'
+          then (
+            select count(distinct doc_id.value)::integer
+            from jsonb_array_elements_text(vr.document_ids) as doc_id(value)
+          )
+        else coalesce(cdc.document_count, 0)
+      end as document_count
+    from visible_reviews vr
+    left join cell_document_counts cdc
+      on cdc.review_id = vr.id
   )
   select
     vr.id,
@@ -772,18 +815,83 @@ as $$
     vr.created_at,
     vr.updated_at,
     vr.user_id = p_user_id as is_owner,
-    case
-      when jsonb_typeof(vr.document_ids) = 'array'
-        then (
-          select count(distinct doc_id.value)::integer
-          from jsonb_array_elements_text(vr.document_ids) as doc_id(value)
-        )
-      else coalesce(cdc.document_count, 0)
-    end as document_count
+    rdc.document_count
   from visible_reviews vr
-  left join cell_document_counts cdc
-    on cdc.review_id = vr.id
-  order by vr.created_at desc;
+  join review_document_counts rdc
+    on rdc.id = vr.id
+  order by
+    case
+      when p_sort_key = 'name' and p_sort_direction = 'asc' then lower(coalesce(vr.title, ''))
+      else null
+    end asc,
+    case
+      when p_sort_key = 'name' and p_sort_direction = 'desc' then lower(coalesce(vr.title, ''))
+      else null
+    end desc,
+    case
+      when p_sort_key = 'columns' and p_sort_direction = 'asc' then jsonb_array_length(coalesce(vr.columns_config, '[]'::jsonb))
+      else null
+    end asc,
+    case
+      when p_sort_key = 'columns' and p_sort_direction = 'desc' then jsonb_array_length(coalesce(vr.columns_config, '[]'::jsonb))
+      else null
+    end desc,
+    case
+      when p_sort_key = 'documents' and p_sort_direction = 'asc' then rdc.document_count
+      else null
+    end asc,
+    case
+      when p_sort_key = 'documents' and p_sort_direction = 'desc' then rdc.document_count
+      else null
+    end desc,
+    case
+      when p_sort_key = 'created' and p_sort_direction = 'asc' then vr.created_at
+      else null
+    end asc,
+    case
+      when p_sort_key = 'created' and p_sort_direction = 'desc' then vr.created_at
+      else null
+    end desc,
+    vr.created_at desc,
+    vr.id asc
+  limit greatest(coalesce(p_limit, 20), 1)
+  offset greatest(coalesce(p_offset, 0), 0);
+$$;
+
+create or replace function public.get_tabular_reviews_overview(
+  p_user_id text,
+  p_user_email text default null,
+  p_project_id text default null
+)
+returns table (
+  id uuid,
+  project_id uuid,
+  user_id text,
+  title text,
+  columns_config jsonb,
+  document_ids jsonb,
+  workflow_id uuid,
+  shared_with jsonb,
+  created_at timestamptz,
+  updated_at timestamptz,
+  is_owner boolean,
+  document_count integer
+)
+language sql
+stable
+as $$
+  select *
+  from public.get_tabular_reviews_overview(
+    p_user_id,
+    p_user_email,
+    p_project_id,
+    'all',
+    2147483647,
+    0,
+    null,
+    'created',
+    'desc'
+  );
 $$;
 
 create table if not exists public.tabular_review_chats (