Db pagination for tabular reviews - #263
Merged
Merged
Conversation
Collaborator
|
Added a follow-up reliability pass in
Validation completed:
|
willchen96
approved these changes
Jul 26, 2026
willchen96
marked this pull request as ready for review
July 26, 2026 16:49
Collaborator
|
Addressed the remaining review feedback in d6b35c9:
Verification completed:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
For the Tabular Reviews page, this moves the keyword search and order by functions from the data table into the backend, and adds pagination with lazy load fetching.
Why / Motivation
First part of the pagination feature request from the discord chat.
Changes
Implement offset based paging in the database for the tabular view.
Tradeoffs & risks
Considered multiple UI paging strategies and interface options, against the potential perf impacts and scope for the number of records considering this is an open source project and may be used in multi-tenanted environments.
This is an implementation on a single view, and once the approach is reviewed and approved, should be mirrored in the other views which require paging.
How verified
Added some tests, but mainly by manual testing in my local instance manually populated with seed data to test pagination.
Checklist
git diffand removed unrelated changes..envfiles committed.