Skip to content

Fix failing workflows - update deprecated GitHub Actions and platform issues #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
OhACD merged 2 commits into from
Dec 28, 2025
Merged

Fix failing workflows - update deprecated GitHub Actions and platform issues #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf777d8
Initial plan
Copilot Dec 28, 2025
b44e423
Update GitHub Actions to latest versions and fix workflow issues
Copilot Dec 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 9 additions & 18 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
distribution: 'temurin'

- name: Cache Gradle packages
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: |
~/.gradle/caches
Expand All @@ -52,7 +52,7 @@ jobs:
if: always()

- name: Upload test results
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: always()
with:
name: test-results-java-${{ matrix.java-version }}
Expand Down Expand Up @@ -86,7 +86,7 @@ jobs:
uses: actions/checkout@v4

- name: Download performance reports
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: test-results-java-17
path: build/reports/
Comment on lines 88 to 92
Copy link

Copilot AI Dec 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The performance-analysis job is missing both Java setup and a chmod +x ./gradlew step. Line 126 executes ./gradlew test in a fallback scenario, but this will fail because: 1) Java is not installed (no setup-java step), and 2) the gradlew file won't have executable permissions. Add both a "Set up JDK" step and a "Make gradlew executable" step after the checkout step, similar to what was done in the build job.

Copilot uses AI. Check for mistakes.
Expand Down Expand Up @@ -141,7 +141,7 @@ jobs:
distribution: 'temurin'

- name: Cache Gradle packages
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: |
~/.gradle/caches
Expand All @@ -162,7 +162,7 @@ jobs:
ls -la build/libs/

- name: Upload build artifacts
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: matchbox-plugin
path: build/libs/Matchbox-*.jar
Expand All @@ -177,18 +177,18 @@ jobs:
uses: actions/checkout@v4

- name: Download build artifacts
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: matchbox-plugin
path: build/libs/

- name: Create release
uses: actions/create-release@v1
uses: softprops/action-gh-release@v2
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
tag_name: v${{ github.run_number }}
release_name: Matchbox v${{ github.run_number }}
name: Matchbox v${{ github.run_number }}
body: |
## 🚀 Automated Release

Expand All @@ -208,16 +208,7 @@ jobs:
- [API Documentation](MatchboxAPI_Docs.md)
draft: false
prerelease: false

- name: Upload release asset
uses: actions/upload-release-asset@v1
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
upload_url: ${{ steps.create_release.outputs.upload_url }}
asset_path: build/libs/Matchbox-*.jar
asset_name: Matchbox-${{ github.run_number }}.jar
asset_content_type: application/java-archive
files: build/libs/Matchbox-*.jar

# Performance regression detection for PRs
performance-regression-check:
Expand Down
5 changes: 4 additions & 1 deletion .github/workflows/javadoc.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,11 @@ jobs:
distribution: 'temurin'
java-version: '21'

- name: Make gradlew executable
run: chmod +x ./gradlew

- name: Build Javadoc
run: ./gradlew.bat javadoc javadocJar --no-daemon
run: ./gradlew javadoc javadocJar --no-daemon

- name: Upload Javadoc artifact
uses: actions/upload-artifact@v4
Expand Down
7 changes: 5 additions & 2 deletions .github/workflows/publish-docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
- name: Set up JDK
uses: actions/setup-java@v4
with:
distribution: temurin
distribution: 'temurin'
java-version: '17'

- name: Cache Gradle
Expand All @@ -31,11 +31,14 @@ jobs:
key: gradle-${{ runner.os }}-${{ hashFiles('**/*.gradle*','**/gradle-wrapper.properties') }}
restore-keys: gradle-${{ runner.os }}-

- name: Make gradlew executable
run: chmod +x ./gradlew

- name: Build Javadoc
run: ./gradlew javadoc --no-daemon --console=plain

- name: Deploy to GitHub Pages
uses: peaceiris/actions-gh-pages@v3
uses: peaceiris/actions-gh-pages@v4
with:
publish_dir: ./build/docs/javadoc
publish_branch: gh-pages
Expand Down
Empty file modified gradlew
100644 → 100755
View file
Open in desktop
Empty file.