-
Notifications
You must be signed in to change notification settings - Fork 0
Fix failing workflows - update deprecated GitHub Actions and platform issues #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: OhACD <220384685+OhACD@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes failing workflows by updating deprecated GitHub Actions and resolving platform-specific configuration issues. The workflows had been failing since December 22nd due to deprecated v3 actions and incorrect platform assumptions.
Key changes:
- Updated GitHub Actions from v3 to v4 (cache, upload-artifact, download-artifact)
- Migrated release workflow from deprecated actions/create-release + actions/upload-release-asset to softprops/action-gh-release@v2
- Added missing gradlew file and chmod +x steps to ensure executability on Ubuntu runners
- Fixed platform-specific issues (gradlew.bat → gradlew, quoted distribution parameter)
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| gradlew | Added missing Gradle wrapper script for Unix/Linux systems |
| .github/workflows/publish-docs.yml | Updated peaceiris/actions-gh-pages to v4, added chmod for gradlew, quoted distribution parameter |
| .github/workflows/javadoc.yml | Fixed gradlew.bat → gradlew for Ubuntu, added chmod step, updated upload-artifact to v4 |
| .github/workflows/ci.yml | Updated cache/upload/download-artifact actions to v4, consolidated release creation into single action, but missing chmod +x in some jobs |
Comments suppressed due to low confidence (1)
.github/workflows/ci.yml:151
- The
buildjob is missing achmod +x ./gradlewstep before executing Gradle commands. While the cache action was updated to v4, the job will fail when it attempts to run./gradlew build -x testbecause the newly added gradlew file may not have executable permissions when checked out. Add a "Make gradlew executable" step after this cache step, similar to what was done in thetestjob (line 38) and thejavadoc.ymlworkflow (line 23).
- name: Cache Gradle packages
uses: actions/cache@v4
with:
path: |
~/.gradle/caches
~/.gradle/wrapper
key: ${{ runner.os }}-gradle-${{ hashFiles('**/*.gradle*', '**/gradle-wrapper.properties') }}
restore-keys: |
${{ runner.os }}-gradle-
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - name: Download performance reports | ||
| uses: actions/download-artifact@v3 | ||
| uses: actions/download-artifact@v4 | ||
| with: | ||
| name: test-results-java-17 | ||
| path: build/reports/ |
Copilot
AI
Dec 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The performance-analysis job is missing both Java setup and a chmod +x ./gradlew step. Line 126 executes ./gradlew test in a fallback scenario, but this will fail because: 1) Java is not installed (no setup-java step), and 2) the gradlew file won't have executable permissions. Add both a "Set up JDK" step and a "Make gradlew executable" step after the checkout step, similar to what was done in the build job.
All workflows have been failing since Dec 22 due to deprecated GitHub Actions (v3→v4 migrations) and platform-specific configuration errors.
Updated Actions
actions/cache,actions/upload-artifact,actions/download-artifact: v3 → v4actions/create-release@v1+actions/upload-release-asset@v1→softprops/action-gh-release@v2peaceiris/actions-gh-pages: v3 → v4Fixed Platform Issues
./gradlew.bat→./gradlew(Ubuntu runner)distribution: temurin→distribution: 'temurin'chmod +x ./gradlewto all workflowsSimplified
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
repo.papermc.io/usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java -XX:+UseG1GC -XX:+ParallelRefProcEnabled -XX:MaxGCPauseMillis=200 -XX:+UnlockExperimentalVMOptions -XX:+DisableExplicitGC -XX:+AlwaysPreTouch -XX:G1NewSizePercent=30 -XX:G1MaxNewSizePercent=40 -XX:G1HeapRegionSize=8m -XX:G1ReservePercent=20 -XX:G1HeapWastePercent=5 -XX:G1MixedGCCountTarget=4 -XX:InitiatingHeapOccupancyPercent=15 -XX:G1MixedGCLiveThresholdPercent=90 -XX:G1RSetUpdatingPauseTimePercent=5 -XX:SurvivorRatio=32 -XX:+PerfDisableSharedMem -XX:MaxTenuringThreshold=1 --add-opens=java.base/java.util=ALL-UNNAMED(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.