Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix ci build #1390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ci build #1390
Changes from all commits
688f009
cc2b299
c21f317
ebf6cc0
b4adb09
f3edce2
d518f7c
07f829d
2dc17c3
1433d3a
d2289d4
fa22696
75bcc68
50efdf7
3cf06a9
877b90a
513001f
86170b0
670a110
91dee39
115b097
4465cf2
60f98ea
e51dc19
3ff1a0f
fa5c652
35aa9e7
577ef4c
e49ff4b
43e76de
cfd361d
3b84a99
a758cdb
4c9c658
70d3bc9
d2dca92
9884f55
ae6f10b
d5cf838
abae923
99b3982
0867a29
c5db48b
bb408c0
d4d7402
eda0711
bd7fc86
1b54248
b5d6508
873f6ca
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nedvedba why this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we weren't installing any of the dependencies with the 'unify' option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably need a way to install all dependencies that is not distro specific, I really don't like using apt for this it makes things brittle.