Fix ci build #1390
Merged
Fix ci build #1390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's Guide by SourceryThis PR updates the CI build environment to Ubuntu 24.04 and upgrades the protobuf package version. Additionally, it replaces No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @JoshuaSBrown - I've reviewed your changes - here's some feedback:
Overall Comments:
- It would be good to understand why these dependencies are being updated.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
3 tasks
…ially support 3.11
…ially support 3.11
Libsodium folder version number.
Make paths explicit.
JoshuaSBrown
commented
May 7, 2025
JoshuaSBrown
commented
May 7, 2025
JoshuaSBrown
commented
May 7, 2025
JoshuaSBrown
commented
May 7, 2025
JoshuaSBrown
commented
May 7, 2025
JoshuaSBrown
commented
May 7, 2025
JoshuaSBrown
commented
May 7, 2025
JoshuaSBrown
commented
May 7, 2025
JoshuaSBrown
commented
May 7, 2025
JoshuaSBrown
commented
May 7, 2025
JoshuaSBrown
commented
May 7, 2025
Co-authored-by: Joshua S Brown <[email protected]>
Co-authored-by: Joshua S Brown <[email protected]>
Co-authored-by: Joshua S Brown <[email protected]>
Co-authored-by: Joshua S Brown <[email protected]>
… method (#1417) * changed install scripts to be consistent * added sudo check
JoshuaSBrown
commented
May 13, 2025
| @@ -66,7 +66,7 @@ COPY ./scripts/install_authz_dependencies.sh ${BUILD_DIR}/scripts/ | |||
| COPY ./scripts/copy_dependency.sh ${BUILD_DIR}/scripts/ | |||
|
|
|||
| RUN ${BUILD_DIR}/scripts/generate_datafed.sh | |||
| RUN DEBIAN_FRONTEND=noninteractive TZ=Etc/UTC ${BUILD_DIR}/scripts/install_authz_dependencies.sh unify | |||
| RUN DEBIAN_FRONTEND=noninteractive TZ=Etc/UTC ${BUILD_DIR}/scripts/install_authz_dependencies.sh | |||
There was a problem hiding this comment.
@nedvedba why this change?
There was a problem hiding this comment.
Looks like we weren't installing any of the dependencies with the 'unify' option.
JoshuaSBrown
commented
May 13, 2025
Comment on lines
+67
to
+82
| install_python() { | ||
| if [ ! -e "${DATAFED_DEPENDENCIES_INSTALL_PATH}/.python_installed-${DATAFED_PYTHON_VERSION}" ]; then | ||
| # Check if the deadsnakes repository has already been added to avoid issues with gpg | ||
| if ! grep -qr '^deb .\+deadsnakes' /etc/apt/sources.list.d/; then | ||
| "$SUDO_CMD" apt update | ||
| "$SUDO_CMD" apt install -y software-properties-common | ||
| "$SUDO_CMD" add-apt-repository -y ppa:deadsnakes/ppa | ||
| "$SUDO_CMD" apt update | ||
| fi | ||
|
|
||
| "$SUDO_CMD" apt install -y "python${DATAFED_PYTHON_VERSION}" "python${DATAFED_PYTHON_VERSION}-dev" "python${DATAFED_PYTHON_VERSION}-venv" "python${DATAFED_PYTHON_VERSION}-distutils" | ||
|
|
||
| touch "${DATAFED_DEPENDENCIES_INSTALL_PATH}/.python_installed-${DATAFED_PYTHON_VERSION}" | ||
| fi | ||
| } | ||
|
|
There was a problem hiding this comment.
We probably need a way to install all dependencies that is not distro specific, I really don't like using apt for this it makes things brittle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Tasks
Summary by Sourcery
Update CI and dependency configurations to improve build compatibility and dependency management
Build:
CI: