Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix KeyError 'changes_to_release_date' #26

Merged
merged 4 commits into from
Nov 18, 2024
Merged

Fix KeyError 'changes_to_release_date' #26

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cf7bc34
Fix `KeyError 'changes_to_release_date'`
zerolab Nov 15, 2024
6287167
Fix typo in Analysis series help text
zerolab Nov 15, 2024
da53e25
Further tidy ups
zerolab Nov 18, 2024
0b105ca
fixup! Further tidy ups
zerolab Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cms/analysis/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ class AnalysisSeries(RoutablePageMixin, Page):
HelpPanel(
content=_(
"This is a container for Analysis series. It provides the <code>/latest</code>,"
"<code>/previous-release</code> evergreen paths, as well as the actual analysis pages. "
"<code>/previous-releases</code> evergreen paths, as well as the actual analysis pages. "
"Add a new Analysis page under this container."
)
),
Expand Down
2 changes: 1 addition & 1 deletion cms/release_calendar/forms.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ def clean(self) -> dict:
if (
self.instance.release_date
and self.instance.release_date != cleaned_data["release_date"]
and len(self.instance.changes_to_release_date) == len(cleaned_data["changes_to_release_date"])
and len(self.instance.changes_to_release_date) == len(cleaned_data.get("changes_to_release_date", []))
):
# A change in the release date requires updating changes_to_release_date
raise ValidationError(
Expand Down
Loading