Fix KeyError 'changes_to_release_date'
#26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cannot quite reproduce in tests nor locally
ababic
approved these changes
Nov 15, 2024
There was a problem hiding this comment.
Do we need to enforce using .get on cleaned_data. When can we expect the keys to be populated, I'm seeing inconsistent behaviour of it sometimes existing. While testing this, I got a KeyError on status key https://github.com/ONSdigital/dis-wagtail/pull/26/files#diff-97e098c994ca593ce24412351be5632c9b77fdf54cc70d6f184c45020644d481R29
To recreate:
- Add a release calendar entry with title, summary and status Provisional then Save draft.
- Change status to Published and click Save draft and then you should see the key error in the logs.
|
@MebinAbraham done da53e25. Added to the list to investigate in Wagtail core. |
MebinAbraham
approved these changes
Nov 18, 2024
MebinAbraham
approved these changes
Nov 18, 2024
nehakerung
pushed a commit
that referenced
this pull request
Nov 18, 2024
nehakerung
pushed a commit
that referenced
this pull request
Nov 18, 2024
nehakerung
pushed a commit
that referenced
this pull request
Nov 18, 2024
nehakerung
pushed a commit
that referenced
this pull request
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cannot quite reproduce in tests nor locally. Follow up to #16
What is the context of this PR?
Sentry issue screenshot
How to review
Just review the code.
Follow-up Actions
Monitor Sentry and follow up with any other tweaks.