Analysis page and series #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…igned with djhtml
adds a few extra files to the ignore. and explicitly filters the RemovedInDjango60Warning
* Bump Wagtail to 6.3 * Generate migrations for custom images/docs
Base automatically changed from
chore/wagtail-6.3
to
feature/release-calendar-pages
November 5, 2024 16:03
ababic
reviewed
Nov 13, 2024
ababic
reviewed
Nov 13, 2024
ababic
reviewed
Nov 13, 2024
ababic
reviewed
Nov 13, 2024
something, something Promises
AWitcherONS
reviewed
Nov 13, 2024
MebinAbraham
approved these changes
Nov 14, 2024
AWitcherONS
approved these changes
Nov 14, 2024
Merged
sanjeevz3009
pushed a commit
that referenced
this pull request
Nov 15, 2024
* Add skeleton models for Theme / Topic pages
* Add base analysis series and page models
* Use a custom icon for the contact detail snippet
* Update the StreamField block template to pass the block ID to its children
* Set parent/subpage types for the new page models
* Wire in the analysis page template
* Add series functionality (latest/previous releases)
* Add tests and fail if coverage under 90%
* Tidy up based on code review
* Make the accredited / census blocks separate includes
* Include changes to release dates when status is confirmed
* Allow setting the release date when switching to confirmed
* Only allow release date or text, not both
* Prevent release calendar page deletion through the UI
* Move the changes to the release date below contact details
e.g. https://www.ons.gov.uk/releases/disabilitypaygapsintheuk2014to2023
* Switch to using a StreamField for the release page related links
* Disable the "too-few-public-methods" pylint check globally
* Make the equation/ONS embed check reusable
sanjeevz3009
pushed a commit
that referenced
this pull request
Nov 15, 2024
* Add skeleton models for Theme / Topic pages
* Add base analysis series and page models
* Use a custom icon for the contact detail snippet
* Update the StreamField block template to pass the block ID to its children
* Set parent/subpage types for the new page models
* Wire in the analysis page template
* Add series functionality (latest/previous releases)
* Add tests and fail if coverage under 90%
* Tidy up based on code review
* Make the accredited / census blocks separate includes
* Include changes to release dates when status is confirmed
* Allow setting the release date when switching to confirmed
* Only allow release date or text, not both
* Prevent release calendar page deletion through the UI
* Move the changes to the release date below contact details
e.g. https://www.ons.gov.uk/releases/disabilitypaygapsintheuk2014to2023
* Switch to using a StreamField for the release page related links
* Disable the "too-few-public-methods" pylint check globally
* Make the equation/ONS embed check reusable
sanjeevz3009
pushed a commit
that referenced
this pull request
Nov 15, 2024
* Add skeleton models for Theme / Topic pages
* Add base analysis series and page models
* Use a custom icon for the contact detail snippet
* Update the StreamField block template to pass the block ID to its children
* Set parent/subpage types for the new page models
* Wire in the analysis page template
* Add series functionality (latest/previous releases)
* Add tests and fail if coverage under 90%
* Tidy up based on code review
* Make the accredited / census blocks separate includes
* Include changes to release dates when status is confirmed
* Allow setting the release date when switching to confirmed
* Only allow release date or text, not both
* Prevent release calendar page deletion through the UI
* Move the changes to the release date below contact details
e.g. https://www.ons.gov.uk/releases/disabilitypaygapsintheuk2014to2023
* Switch to using a StreamField for the release page related links
* Disable the "too-few-public-methods" pylint check globally
* Make the equation/ONS embed check reusable
nehakerung
pushed a commit
that referenced
this pull request
Nov 18, 2024
* Add skeleton models for Theme / Topic pages
* Add base analysis series and page models
* Use a custom icon for the contact detail snippet
* Update the StreamField block template to pass the block ID to its children
* Set parent/subpage types for the new page models
* Wire in the analysis page template
* Add series functionality (latest/previous releases)
* Add tests and fail if coverage under 90%
* Tidy up based on code review
* Make the accredited / census blocks separate includes
* Include changes to release dates when status is confirmed
* Allow setting the release date when switching to confirmed
* Only allow release date or text, not both
* Prevent release calendar page deletion through the UI
* Move the changes to the release date below contact details
e.g. https://www.ons.gov.uk/releases/disabilitypaygapsintheuk2014to2023
* Switch to using a StreamField for the release page related links
* Disable the "too-few-public-methods" pylint check globally
* Make the equation/ONS embed check reusable
nehakerung
pushed a commit
that referenced
this pull request
Nov 18, 2024
* Add skeleton models for Theme / Topic pages
* Add base analysis series and page models
* Use a custom icon for the contact detail snippet
* Update the StreamField block template to pass the block ID to its children
* Set parent/subpage types for the new page models
* Wire in the analysis page template
* Add series functionality (latest/previous releases)
* Add tests and fail if coverage under 90%
* Tidy up based on code review
* Make the accredited / census blocks separate includes
* Include changes to release dates when status is confirmed
* Allow setting the release date when switching to confirmed
* Only allow release date or text, not both
* Prevent release calendar page deletion through the UI
* Move the changes to the release date below contact details
e.g. https://www.ons.gov.uk/releases/disabilitypaygapsintheuk2014to2023
* Switch to using a StreamField for the release page related links
* Disable the "too-few-public-methods" pylint check globally
* Make the equation/ONS embed check reusable
nehakerung
pushed a commit
that referenced
this pull request
Nov 18, 2024
* Add skeleton models for Theme / Topic pages
* Add base analysis series and page models
* Use a custom icon for the contact detail snippet
* Update the StreamField block template to pass the block ID to its children
* Set parent/subpage types for the new page models
* Wire in the analysis page template
* Add series functionality (latest/previous releases)
* Add tests and fail if coverage under 90%
* Tidy up based on code review
* Make the accredited / census blocks separate includes
* Include changes to release dates when status is confirmed
* Allow setting the release date when switching to confirmed
* Only allow release date or text, not both
* Prevent release calendar page deletion through the UI
* Move the changes to the release date below contact details
e.g. https://www.ons.gov.uk/releases/disabilitypaygapsintheuk2014to2023
* Switch to using a StreamField for the release page related links
* Disable the "too-few-public-methods" pylint check globally
* Make the equation/ONS embed check reusable
nehakerung
pushed a commit
that referenced
this pull request
Nov 18, 2024
* Add skeleton models for Theme / Topic pages
* Add base analysis series and page models
* Use a custom icon for the contact detail snippet
* Update the StreamField block template to pass the block ID to its children
* Set parent/subpage types for the new page models
* Wire in the analysis page template
* Add series functionality (latest/previous releases)
* Add tests and fail if coverage under 90%
* Tidy up based on code review
* Make the accredited / census blocks separate includes
* Include changes to release dates when status is confirmed
* Allow setting the release date when switching to confirmed
* Only allow release date or text, not both
* Prevent release calendar page deletion through the UI
* Move the changes to the release date below contact details
e.g. https://www.ons.gov.uk/releases/disabilitypaygapsintheuk2014to2023
* Switch to using a StreamField for the release page related links
* Disable the "too-few-public-methods" pylint check globally
* Make the equation/ONS embed check reusable
Addition of equation partials
Deleted media files and made lint, format test pass
Repeated code remove, /media added to .gitignore, media file removed
Check tests pass
Custom sign commit
nehakerung
added a commit
that referenced
this pull request
Nov 19, 2024
* Standard_pages app creation * Django models for information page updated and the template for the information page tweaked * Replace `pytest` with Django's built-in runner (#18) * Release calendar pages (#16) * Replace Docker Desktop setup with Colima (#24) * Add Cookie banner and Google Tag Manager snippet (#19) * Analysis page and series (#20) * Addition of equation partials * Repeated code remove, /media added to .gitignore, media file removed * Related pages InlinePanel added. Add Info Template updated. --------- Co-authored-by: Neha <[email protected]> Co-authored-by: Sanjeev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
https://jira.ons.gov.uk/browse/CMS-70
This PR builds on #17 and:
How to review
See screencasts:
Check it out locally, run migrations. Create a theme page, then a topic page under it, then an Analysis series and finally one or more Analysis pages.
Follow-up Actions