Add Information Page #21

sanjeevz3009 · 2024-11-07T15:38:15Z

What is the context of this PR?

JIRA Ticket: https://jira.ons.gov.uk/browse/CMS-179

Create an Information Page model in Wagtail CMS to allow content editors to manage structured information pages.

Changes and Additions

HTML template created for the information page.
Django Model created for Information Page

How to review

Spin up the project in your local machine
Run the linters, code formatters and run the tests locally to make sure it's passing

Create an information page

Go to localhost:8000
Navigate to the Wagtail admin site localhost:8000/admin
Within Wagtail Admin -> Pages -> Home -> Add Child Page
Then you should be able to fill in the content of the information page and publish.

Information Page Example

Follow-up Actions

List any follow-up actions (if applicable), like needed documentation updates or additional testing.

zerolab

Great start!

Added a few notes and suggestions as a first pass.

cms/jinja2/templates/pages/information_page.html

cms/standard_pages/models.py

cms/jinja2/templates/pages/information_page.html

cms/standard_pages/migrations/0002_rename_body_informationpage_content.py

cms/standard_pages/models.py

cms/jinja2/templates/pages/information_page.html

cms/standard_pages/models.py

zerolab

LGTM.

MebinAbraham

Nice work both 👍

cms/static_src/sass/main.scss

cms/release_calendar/models.py

cms/static_src/sass/main.scss

cms/standard_pages/models.py

zerolab

A couple of small changes needed (but lovely first feature 💪🏼 )

cms/jinja2/templates/pages/information_page.html

media/documents/file.txt

MebinAbraham

Nothing else that's not already been raised.

👍

media/documents/file.txt

cms/jinja2/templates/pages/information_page.html

Addition of InformationPage class in models Changes to InformationPage class models Front end creation Addition of template location and minor changes on information_page template for testing Added cms.standard_pages to installed_apps Updated apps.py for standard_pages to be similar to pre-existing apps Modified InformationPage in models Updated template for informationPage Modified models for standard_pages Modified front end working branch

…nformation page tweaked

* Replace `pytest` with Django's built-in runner * Drop whitenoise public directory * Correctly collect coverage for parallel test runs * Note why certain fixtures are created with each test

…hortened and migration file regenerated

…d to reflect the InformationPage model changes

…ired to be entered by the user

* Add the Contact Details snippet https://jira.ons.gov.uk/browse/CMS-80 * Add a basic table block * Add the release calendar app with models * Programmatically create the release calendar index * Add the basic templates * Add a base form class for easier validation * Add icons to the various panels * Add validation logic * Update templates * Add tests * Expand core tests * Expand coverage configuration adds a few extra files to the ignore. and explicitly filters the RemovedInDjango60Warning * Tidy up based on code review * Prevent release calendar page deletion through the UI * Move the changes to the release date below contact details e.g. https://www.ons.gov.uk/releases/disabilitypaygapsintheuk2014to2023 * Fail if under 90% test coverage

Moved parent_page code Removed extra blank lines for lint.py

* Comment out the scheduler image * Remove scheduler from Procfile

* Add skeleton models for Theme / Topic pages * Add base analysis series and page models * Use a custom icon for the contact detail snippet * Update the StreamField block template to pass the block ID to its children * Set parent/subpage types for the new page models * Wire in the analysis page template * Add series functionality (latest/previous releases) * Add tests and fail if coverage under 90% * Tidy up based on code review * Make the accredited / census blocks separate includes * Include changes to release dates when status is confirmed * Allow setting the release date when switching to confirmed * Only allow release date or text, not both * Prevent release calendar page deletion through the UI * Move the changes to the release date below contact details e.g. https://www.ons.gov.uk/releases/disabilitypaygapsintheuk2014to2023 * Switch to using a StreamField for the release page related links * Disable the "too-few-public-methods" pylint check globally * Make the equation/ONS embed check reusable Addition of equation partials Deleted media files and made lint, format test pass Repeated code remove, /media added to .gitignore, media file removed Check tests pass Custom sign commit

* Fix `KeyError 'changes_to_release_date'` Cannot quite reproduce in tests nor locally * Fix typo in Analysis series help text * Further tidy ups

cms/jinja2/templates/pages/information_page.html

zerolab requested changes Nov 7, 2024

View reviewed changes

sanjeevz3009 marked this pull request as ready for review November 7, 2024 17:38

sanjeevz3009 requested a review from a team as a code owner November 7, 2024 17:38

MebinAbraham reviewed Nov 8, 2024

View reviewed changes

cms/standard_pages/migrations/0002_rename_body_informationpage_content.py Outdated Show resolved Hide resolved

cms/standard_pages/models.py Outdated Show resolved Hide resolved

MebinAbraham reviewed Nov 8, 2024

View reviewed changes

cms/jinja2/templates/pages/information_page.html Outdated Show resolved Hide resolved

MebinAbraham reviewed Nov 8, 2024

View reviewed changes

cms/standard_pages/models.py Show resolved Hide resolved

zerolab reviewed Nov 11, 2024

View reviewed changes

cms/standard_pages/models.py Outdated Show resolved Hide resolved

zerolab approved these changes Nov 11, 2024

View reviewed changes

sanjeevz3009 requested a review from MebinAbraham November 11, 2024 13:50

MebinAbraham approved these changes Nov 11, 2024

View reviewed changes

cms/static_src/sass/main.scss Outdated Show resolved Hide resolved

cms/release_calendar/models.py Outdated Show resolved Hide resolved

zerolab reviewed Nov 12, 2024

View reviewed changes

cms/static_src/sass/main.scss Show resolved Hide resolved

zerolab approved these changes Nov 12, 2024

View reviewed changes

MebinAbraham requested changes Nov 12, 2024

View reviewed changes

cms/standard_pages/models.py Show resolved Hide resolved

zerolab requested changes Nov 14, 2024

View reviewed changes

cms/jinja2/templates/pages/information_page.html Outdated Show resolved Hide resolved

media/documents/file.txt Outdated Show resolved Hide resolved

MebinAbraham approved these changes Nov 14, 2024

View reviewed changes

sanjeevz3009 commented Nov 14, 2024

View reviewed changes

media/documents/file.txt Outdated Show resolved Hide resolved

cms/jinja2/templates/pages/information_page.html Outdated Show resolved Hide resolved

zerolab approved these changes Nov 15, 2024

View reviewed changes

MebinAbraham approved these changes Nov 15, 2024

View reviewed changes

nehakerung and others added 12 commits November 18, 2024 15:10

Django models for information page updated and the template for the i…

c1ce98b

…nformation page tweaked

Zombie code removed

78837d2

Unnused files deleted

6ea3fe9

Mirgation file formatted

e2c2c24

django-manager-missing ignore added

0cf3011

TODO comment removed and docstrings added

b9d4ee4

Replace pytest with Django's built-in runner (#18)

fcddd80

* Replace `pytest` with Django's built-in runner * Drop whitenoise public directory * Correctly collect coverage for parallel test runs * Note why certain fixtures are created with each test

Information code formatted

32ef6f3

Docstring rewritten to make it more concise

067757d

Updated body to content

7533f98

Conditional for last_updated added, InformationPage class docstring s…

85a90a4

…hortened and migration file regenerated

sanjeevz3009 and others added 15 commits November 18, 2024 15:10

summary TextField null=true removed and the migration file regenerate…

dc799cd

…d to reflect the InformationPage model changes

Removing the conditional as per requirement the summary field is requ…

790a578

…ired to be entered by the user

InformationPage restrictions added

1ec12d7

Code formatted

1710c56

Comments added

b8a46aa

Moved parent_page code Removed extra blank lines for lint.py

Comment out the scheduler image (#22)

ca6cf26

* Comment out the scheduler image * Remove scheduler from Procfile

Custom CSS added to make video embeds responsive

267cb51

Formatting fixed

432f794

Ignore Unexpected property "left" property-disallowed-list rule

f7e06d6

cms/release_calendar/models.py formating fixed

ec11326

Replace Docker Desktop setup with Colima (#24)

a71808d

Add Cookie banner and Google Tag Manager snippet (#19)

6fa0a43

Fix KeyError 'changes_to_release_date' (#26)

5017772

* Fix `KeyError 'changes_to_release_date'` Cannot quite reproduce in tests nor locally * Fix typo in Analysis series help text * Further tidy ups

nehakerung force-pushed the feature/information-page-CMS-179 branch from 034f54b to 5017772 Compare November 18, 2024 15:12

nehakerung and others added 2 commits November 18, 2024 15:13

Merge branch 'main' into feature/information-page-CMS-179

d55e78a

Missing block added

79e913e

sanjeevz3009 requested review from zerolab and MebinAbraham November 18, 2024 18:40

MebinAbraham approved these changes Nov 19, 2024

View reviewed changes

MebinAbraham reviewed Nov 19, 2024

View reviewed changes

cms/jinja2/templates/pages/information_page.html Outdated Show resolved Hide resolved

Related pages InlinePanel added. Add Info Template updated.

439740b

MebinAbraham approved these changes Nov 19, 2024

View reviewed changes

nehakerung merged commit 0fee2f4 into main Nov 19, 2024
7 checks passed

nehakerung deleted the feature/information-page-CMS-179 branch November 19, 2024 11:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Information Page #21

Add Information Page #21

sanjeevz3009 commented Nov 7, 2024 •

edited

Loading

zerolab left a comment

zerolab left a comment

MebinAbraham left a comment

zerolab left a comment •

edited

Loading

MebinAbraham left a comment

Add Information Page #21

Add Information Page #21

Conversation

sanjeevz3009 commented Nov 7, 2024 • edited Loading

What is the context of this PR?

How to review

Follow-up Actions

zerolab left a comment

Choose a reason for hiding this comment

zerolab left a comment

Choose a reason for hiding this comment

MebinAbraham left a comment

Choose a reason for hiding this comment

zerolab left a comment • edited Loading

Choose a reason for hiding this comment

MebinAbraham left a comment

Choose a reason for hiding this comment

sanjeevz3009 commented Nov 7, 2024 •

edited

Loading

zerolab left a comment •

edited

Loading