[MIG] [18.0] membership delegated partner line#214
Open
[MIG] [18.0] membership delegated partner line#214
Conversation
gfcapalbo
changed the title
gfcapalbo
force-pushed
the
18.0-MIG-membership_delegated_partner_line
branch
16 times, most recently
from
5509399 to
f8eb2a1
Compare
gfcapalbo
changed the title
gfcapalbo
changed the title
gfcapalbo
force-pushed
the
18.0-MIG-membership_delegated_partner_line
branch
from
f8eb2a1 to
f03490a
Compare
Kiplangatdan
suggested changes
Nov 7, 2025
| ) | ||
| def _compute_partner(self): | ||
| """Change associated membership lines if delegated member is changed. | ||
| NOTE: This is required due to the weird way that account.move in parent |
Member
There was a problem hiding this comment.
@gfcapalbo Perhaps this was already solved in v18 and this override is not needed anymore?
Author
There was a problem hiding this comment.
Yes. but the two modules are incompatible. membership_delegated_partner_line does not depend on membership_delegated_partner, in fact they are incompatible and should not be installed together.
So repeating the _compute_partner here as is done in https://github.com/OCA/vertical-association/blob/18.0/membership_delegated_partner/models/membership_line.py#L17 is necessary.
gfcapalbo
force-pushed
the
18.0-MIG-membership_delegated_partner_line
branch
2 times, most recently
from
1c8c361 to
602a373
Compare
Kiplangatdan
approved these changes
Nov 11, 2025
gfcapalbo
force-pushed
the
18.0-MIG-membership_delegated_partner_line
branch
from
602a373 to
362ba20
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migration from v14 to v18.
module requires uninstalling membership_delegated_partner and to run a sql script before that to be installed.
we have no mechanism for "blocks" or "incompatible_with" in manifest for now
I would like to add init_hook blocking installation if membership_delegated_partner. the error will return the basic instructions to follow to correctly install the module.
This small improvement, unfortunately makes test fail, asking for OCA-way to bypass small problem.
Delivering the Current MR has same functionality as old v14.
If we want the pre_init_hook (ready to go on another branch) i need to understand how could this be compatible with OCA CI.