Conversation
| # indirect unrealeased dependencies | ||
| #"odoo-addons-design-themes==18.0.*", | ||
| # Add some constraints to Odoo deps that should be in their setup.py | ||
| "pyyaml==6.0.2", |
There was a problem hiding this comment.
Where did you get this requirement from?
| #"odoo-addons-design-themes==18.0.*", | ||
| # Add some constraints to Odoo deps that should be in their setup.py | ||
| "pyyaml==6.0.2", | ||
| "appdirs==1.4.4", |
There was a problem hiding this comment.
And this one? I can go on for each module, but the general question would be:
Can you base yourself on:
https://github.com/odoo/odoo/blob/18.0/requirements.txt
Because basically that's all that we need, any other requirements and their versions should be defined in the manifest of the OCA modules and not here. For example this one (just as an example, this particular module is not used in this project)
| "manifestoo>=1.0", | ||
| "odoo-test-helper", | ||
| "websocket-client", | ||
| ] |
There was a problem hiding this comment.
What would be nice if, in our PR, we can see which has been taken over from the old 14.0 file and which is added as a change to 18.0. So for this we can pull over the original commit(s) using a technical git command, and then put our changes on top. The technical commands to do this are roughly these
which would translate in this case to something like
$ git clone https://github.com/OCA/$repo -b 14.0
$ cd $repo
$ git checkout -b 18.0-add-pyproject-toml origin/18.0
$ git format-patch --keep-subject --stdout origin/18.0..origin/14.0 -- pyproject.toml | git am -3 --keep
And then overwrite pyproject.toml with the current file with your edits, and commit the changes:
$ cp /tmp/pyproject.toml .
$ git commit -m "[MIG] pyproject.toml 14 to 18"
|
|
||
| # unreleased dependency, add it to test-requirements.txt to let the | ||
| # test pipeline to use it as well | ||
| #odoo-addons-design-themes = { git = "https://github.com/acsone/design-themes", branch = "14.0-with-pyproject" } |
There was a problem hiding this comment.
I think we can leave this one out completely, we don't need a website theme
| # unreleased dependency, add it to test-requirements.txt to let the | ||
| # test pipeline to use it as well | ||
| #odoo-addons-design-themes = { git = "https://github.com/acsone/design-themes", branch = "14.0-with-pyproject" } | ||
| #odoo18-addon-website-apps-store = { git = "https://github.com/OCA/apps-store", rev = "refs/tree/18.0/head"} |
There was a problem hiding this comment.
This can be left out completely, we are deinstalling the app store modules as part of the migration
|
|
||
| # Example to develop module from an other repository | ||
| # installing in editable mode | ||
| # odoo14-addon-membership-delegated-partner-line = { path = "src/vertical-association/setup/membership_delegated_partner_line", editable = true } |
There was a problem hiding this comment.
This module is added here:
So for that I think we should add something like:
odoo18-addon-membership-delegated-partner-line = { path = "https://github.com/gfcapalbo/membership", branch = "18.0-MIG-membership_delegated_partner_line" }
Until it gets merged of course
2 participants
No description provided.