[12.0][MIG] pos_tare w/ barcode by Fkawala · Pull Request #491 · OCA/pos

Fkawala · 2020-05-17T09:32:05Z

Following up our discussion with @legalsylvain here #436 and there #447 Sylvain and I decided to split the work related to tare in two parts.

The first part handles manual tare input (as described in [12.0] [ADD] pos_tare #436) and barcode base tare input (as described in [9.0] [ADD] sell loose goods using tare barcode label #447).
The second part, to be released afterwards, handles the tare barcode label printing from the POS UI (as described in [9.0] [ADD] sell loose goods using tare barcode label #447).

This PR covers the first part. The second part will be delivered later next week.

OCA-git-bot · 2020-05-17T09:32:10Z

Hi @Fkawala,
some modules you are maintaining are being modified, check this out!

legalsylvain · 2020-05-19T09:29:04Z

Hi @Fkawala. I'm currently reviewing this PR.
I'll do a PR against your, to change something.
kind regards.

Fkawala · 2020-05-19T09:30:41Z

Hi @Fkawala. I'm currently reviewing this PR.
I'll do a PR against your, to change something.
kind regards.

Works for me!

Fkawala · 2020-06-15T19:09:27Z

@legalsylvain this PR is pending a formal test with an ESCPOS printer. I'll try to get that done tomorrow. In the meantime would you have some spare cycles to review the code?

@vvrossem this PR is the base layer for a proper tare / gross weight handling in the POS. It adds a "Tare" button and includes @legalsylvain's nice rework of the scale screen (first introduced in #436). This PR features the gross weight / Tare / net weight display on receipt (works for web print and proxy print). This PR is meant to become a dependency for #470 that you've already reviewed a while ago. Do you think you'll have time to review this? If not would you be kind enough to bounce it back to someone else at CoopITEasy? Thank you in advance.

Fkawala · 2020-06-15T19:11:25Z

The CI tests fail b/c:

odoo.exceptions.UserError: ("You try to install module 'pos_tare' that depends on module 'base_fontawesome'.\nBut the latter module is not available in your system.", '')

I'm not sure how to fix that!?

Fkawala · 2020-06-15T19:23:14Z

Sneak peek at the UI changes:

vvrossem

Impressive one!

pos_tare/static/src/js/screens.js

vvrossem · 2020-06-16T13:29:11Z

pos_tare/static/src/js/screens.js

+        check_sanitize_value: function (input_name) {
+            var res = this.$(input_name)[0].value.replace(',', '.').trim();
+            if (isNaN(res)) {
+                this.$(input_name).css("background-color", "#F66");
+                return undefined;
+            }
+            this.$(input_name).css("background-color", "#FFF");
+            return parseFloat(res, 10);
+        },


Kudos go to @legalsylvain on this (and most of the code actually).

vvrossem · 2020-06-16T13:31:20Z

pos_tare/static/src/js/screens.js

+        validate_order: function(options) {
+            var order = this.pos.get_order();
+            var orderlines = Array.from(order.get_orderlines());
+
+            if (orderlines.some(leq_zero_qty)) {
+                var _super_validate_order = this._super.bind(this);
+                var wrong_orderline = orderlines.find(leq_zero_qty);
+                var wrong_product = wrong_orderline.get_product().display_name;
+                this.gui.show_popup('confirm', {
+                    title: _t('Quantity lower or equal to zero'),
+                    body:  _.str.sprintf(
+                        _t("The quantity for \"%s\" is lower or equal to" +
+                        " zero. Call for help unless you're perfectly" +
+                        " sure you are doing right."), wrong_product),
+                    confirm: function() {
+                        _super_validate_order();
+                    },
+                });
+                return;
+            }
+            return this._super(options);
+        },


Glad you liked it! Thank you for the review :)

vvrossem · 2020-06-16T13:47:22Z

The CI tests fail b/c:

odoo.exceptions.UserError: ("You try to install module 'pos_tare' that depends on module 'base_fontawesome'.\nBut the latter module is not available in your system.", '')

I'm not sure how to fix that!?

Neither do I, but I noticed the following logs appear in the console on the pos.config view:

Non loaded modules:       
Array [ "base_fontawesome5.FormRenderer", "base_fontawesome5.ListRenderer" ]

Fkawala · 2020-06-16T13:53:49Z

The CI tests fail b/c:
odoo.exceptions.UserError: ("You try to install module 'pos_tare' that depends on module 'base_fontawesome'.\nBut the latter module is not available in your system.", '')
I'm not sure how to fix that!?

Neither do I, but I noticed the following logs appear in the console on the pos.config view:
Non loaded modules:       
Array [ "base_fontawesome5.FormRenderer", "base_fontawesome5.ListRenderer" ]

Not sure how to read what you sent. The dependency is expected (we are trying to find a nice icon to make the tare information more explicit). The CI crash is kind of expected since it does not have the dependency (https://github.com/OCA/server-tools/tree/12.0/base_fontawesome) available.

legalsylvain · 2020-06-16T13:59:36Z

this commit should fix the problem.
could you rebase ?

Fkawala · 2020-06-16T14:20:59Z

@legalsylvain thank you!

Fkawala · 2020-06-24T16:21:16Z

Howdy, can we try to close this one in what is left of this week?

legalsylvain · 2020-06-24T16:34:40Z

it seems you have some conflicts. could you try to fix it ? I guess a rebase should solve the issue.

Fkawala · 2020-07-04T10:59:05Z

Hello @legalsylvain, hope you're doing good! Am kind of lost with the codecov tool. Would you be able to provide any guidance to get that working? I looked around in codecov but https://codecov.io/gh/OCA/pos/tree/aa2ffbf91645ab059a36fe08b74a0f367b209cd0/pos_tare/models looks ok to me and I don't know what to do. Thank you!

legalsylvain · 2020-07-06T09:38:29Z

Hi @Fkawala.
regarding codecov, it's not a blocking point. it just indicative to see if the coverage is good or not. for the current case, I don't understand why a 100% covered code make the ratio down...

I made some little improvment here : could you review it ? Fkawala#5

thanks !

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: pos-9.0/pos-9.0-pos_barcode_tare Translate-URL: https://translation.odoo-community.org/projects/pos-9-0/pos-9-0-pos_barcode_tare/

…. Apply tare on selected order item.

[ADD] barcode nomenclature for tare [ADD] tare field on pos.order.line model [ADD] Tare button in PoS numpad [IMP] handle correctly different UoM [IMP] add warning at checkout if qty <=0 [IMP] display gross and tare weight for each line Co-authored-by: François Kawala <[email protected]> Co-authored-by: Sylvain LE GAL <[email protected]>

Fkawala · 2020-07-23T09:40:51Z

Could we merge and close this PR? Could/Should I do it my self as the maintainer? Thank you and have a nice day!

OCA-git-bot · 2020-07-23T10:00:01Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Fkawala · 2020-07-23T10:02:48Z

/ocabot merge nobump

OCA-git-bot · 2020-07-23T10:03:05Z

Sorry @Fkawala you are not allowed to merge.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

legalsylvain · 2020-07-23T13:52:50Z

/ocabot merge patch

OCA-git-bot · 2020-07-23T13:53:04Z

On my way to merge this fine PR!
Prepared branch 12.0-ocabot-merge-pr-491-by-legalsylvain-bump-patch, awaiting test results.

Fkawala · 2020-07-23T13:54:45Z

@legalsylvain Merci!

OCA-git-bot · 2020-07-23T14:05:24Z

Congratulations, your PR was merged at 695ed15. Thanks a lot for contributing to OCA. ❤️

Fkawala changed the title ~~[12.0][MIG] pos_tare & pos_barcode_tare (partially)~~ [12.0][MIG] pos_tare w/ barcode May 18, 2020

This was referenced May 24, 2020

12.0 add pos manual weight entry grap/grap-odoo-incubator#50

Closed

[12.0] [ADD] pos_tare #436

Closed

[ADD] pos_container #498

Closed

vvrossem approved these changes Jun 16, 2020

View reviewed changes

Fkawala added 11 commits July 6, 2020 14:37

Barcode tare.

b9e5e48

OCA guidelines.

9ae5383

Fix doc.

800f792

Fix PEP8.

9ef8c08

Correct namespace + removed console log.

ee6aba1

Correct model naming.

f74cfaf

Better readme.

1ad4361

On single namespace.

5fb08c6

Fix missing _t.

1aefe54

Barcode prefix is read from barcode parser.

c911e94

Fix readme.

c895763

oca-transbot and others added 8 commits July 6, 2020 14:37

Update translation files

853b74e

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: pos-9.0/pos-9.0-pos_barcode_tare Translate-URL: https://translation.odoo-community.org/projects/pos-9-0/pos-9-0-pos_barcode_tare/

Set maintainers for three modules.

f9c9e5a

[UPD] README.rst

9da3822

Migration from v9 to v12

6d18713

Better label rendering for web printing.

ada72b0

Export objects to be used in self weighing addon. Fix tare formatting…

2d75e66

…. Apply tare on selected order item.

[ADD][8.0] pos_tare

e251563

[REF] pos_tare: Black python code

c1d3ff3

legalsylvain force-pushed the 12.0-mig-tare branch 2 times, most recently from 1a52e95 to 9fcd244 Compare July 6, 2020 12:50

legalsylvain force-pushed the 12.0-mig-tare branch from 9fcd244 to 3e88ad3 Compare July 6, 2020 12:53

legalsylvain approved these changes Jul 6, 2020

View reviewed changes

OCA-git-bot added the approved label Jul 6, 2020

OCA-git-bot added the ready to merge label Jul 23, 2020

OCA-git-bot added the bot is merging ⏳ label Jul 23, 2020

OCA-git-bot merged commit ba4ebdf into OCA:12.0 Jul 23, 2020

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Jul 23, 2020

Fkawala mentioned this pull request Aug 27, 2020

[12.0][MIG] pos_tare_generate_barcode #527

Closed

Fkawala deleted the 12.0-mig-tare branch August 31, 2020 06:56

Fkawala restored the 12.0-mig-tare branch August 31, 2020 06:57

Uh oh!

Conversation

Fkawala commented May 17, 2020

Uh oh!

OCA-git-bot commented May 17, 2020

Uh oh!

legalsylvain commented May 19, 2020

Uh oh!

Fkawala commented May 19, 2020

Uh oh!

Fkawala commented Jun 15, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Fkawala commented Jun 15, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Fkawala commented Jun 15, 2020

Uh oh!

vvrossem left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

vvrossem Jun 16, 2020

Choose a reason for hiding this comment

Uh oh!

Fkawala Jun 16, 2020

Choose a reason for hiding this comment

Uh oh!

vvrossem Jun 16, 2020

Choose a reason for hiding this comment

Uh oh!

Fkawala Jun 16, 2020

Choose a reason for hiding this comment

Uh oh!

vvrossem commented Jun 16, 2020

Uh oh!

Fkawala commented Jun 16, 2020

Uh oh!

legalsylvain commented Jun 16, 2020

Uh oh!

Fkawala commented Jun 16, 2020

Uh oh!

Fkawala commented Jun 24, 2020

Uh oh!

legalsylvain commented Jun 24, 2020

Uh oh!

Fkawala commented Jul 4, 2020

Uh oh!

legalsylvain commented Jul 6, 2020

Uh oh!

Fkawala commented Jul 23, 2020

Uh oh!

OCA-git-bot commented Jul 23, 2020

Uh oh!

Fkawala commented Jul 23, 2020

Uh oh!

OCA-git-bot commented Jul 23, 2020

Uh oh!

legalsylvain commented Jul 23, 2020

Uh oh!

OCA-git-bot commented Jul 23, 2020

Uh oh!

Fkawala commented Jul 23, 2020

Uh oh!

OCA-git-bot commented Jul 23, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Fkawala commented Jun 15, 2020 •

edited

Loading

Fkawala commented Jun 15, 2020 •

edited

Loading