Skip to content

[ADD] pos_container#498

Closed
remytms wants to merge 1 commit intoOCA:12.0from
coopiteasy:12.0-pos_container
Closed

[ADD] pos_container#498
remytms wants to merge 1 commit intoOCA:12.0from
coopiteasy:12.0-pos_container

Conversation

@remytms
Copy link

@remytms remytms commented May 28, 2020 •
edited
Loading

This module allows to handle use of reusable containers in POS,
this is useful to handle selling product in bulk without having to calculate
the tare of the container.

Each container is identified by a barcode, the weight is stored in Odoo.

See Readme for more information.

I'm not the author, just the commiter. Credits to :

@remytms
[ADD] pos_container
9fbdfc0 
See Readme for more information.

I'm not the author, just the commiter. Credits to :
- @robin.keunen
- @PierrickBrun
- @vvrossem
chienandalu
chienandalu reviewed May 28, 2020
View reviewed changes
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not adpating delivery packages (stock.quant.package) to pos? Isn't it the same concept?

@legalsylvain
Copy link
Contributor

legalsylvain commented May 28, 2020

Hi @remytms thanks a lot for sharing this module.
There are pending work regarding pos_tare module on 9.0 and 12.0.
V12.0 is quasi ready to review. (some little things to fix with @Fkawala)

It includes part of the feature of your module. (mainly the computation of net and gross weight and the tare field on pos.order.line)

My proposal is to make your module pos_container depend on pos_tare to add the extra feature of containers.

In the other part, I abstain regarding @chienandalu remarks.

thanks !

@legalsylvain legalsylvain added this to the 12.0 milestone Aug 10, 2020
@legalsylvain
Copy link
Contributor

legalsylvain commented Aug 10, 2020

any news regarding @chienandalu remarks and mines ?

thanks !

@robinkeunen
Copy link

robinkeunen commented Aug 11, 2020

@chienandalu that decision dates a bit but, to the best of my memories, we wanted a simple object for tracking the weight of the customers containers while stock.quant.package deals with various type of packaging you have in stock (carton packaging of size x, carton packaging of size y, pallets, ...).

I think we were also a bit afraid of the stock.quant.package model...

@legalsylvain
Copy link
Contributor

legalsylvain commented Aug 11, 2020

Thanks a lot Robin. And did you take a look on pos_tare module ? (Now merged in v12)

@robinkeunen
Copy link

robinkeunen commented Aug 11, 2020

No, I have not, @vvrossem was following this but he's on sick leave until septembre. I won't have time to look at it in the near future... :/

vvrossem added a commit to coopiteasy/cie-pos that referenced this pull request Sep 21, 2020
@vvrossem
[ADD] pos modules used by vracoop :
a5ff2fa 
- pos_customer_display
- pos_customer_display_currency
- pos_hash_cert
- pos_toledo_container
- pos_toledo_product

No need to copy `pos_container` since a PR is opened on `oca/pos`
(OCA/pos#498)

Moved from https://github.com/coopiteasy/pos/tree/12.0-cie-vracoop.
`coopiteasy/pos` is forked from `OCA/pos`. The latter repository
has evolved, new modules are available. The 12.0-cie-vracoop on the
former repository cannot be maintained anymore.
@vvrossem vvrossem mentioned this pull request Sep 21, 2020
Open
@github-actions
Copy link

github-actions bot commented Sep 5, 2021

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 5, 2021
@github-actions github-actions bot closed this Oct 10, 2021
@carmenbianca
Copy link
Member

carmenbianca commented May 9, 2022

@remytms @robinkeunen this PR is still used by us, but has been closed for half a year.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chienandalu chienandalu chienandalu left review comments

Assignees

No one assigned

Labels

stale PR/Issue without recent activity, it'll be soon closed automatically.

Projects

None yet

Milestone

12.0

Development

Successfully merging this pull request may close these issues.

5 participants

@remytms @legalsylvain @robinkeunen @carmenbianca @chienandalu