[9.0] [ADD] sell loose goods using tare barcode label by Fkawala · Pull Request #447 · OCA/pos

Fkawala · 2020-01-28T08:49:54Z

This add-on enables POS to read and print tare barcodes. We print a barcode tare label to sell loose goods in a Bring Your Own pot (BYOC) scheme.

The BYOC scheme has five steps:

The cashier weighs the pot and sticks the tare barcode onto the customer's pot.
The customer go and put loose goods into the labeled pot.
The cashier weighs the pot with loose goods inside. POS computes the price including the pot.
The cashier scans the tare barcode. POS get the pot weight from the barcode. POS subtracts the pot weight from the weight of the latest product. POS sets the billable price for the loose goods.
The customer pays.

This add-on adds a news screen to POS to print (web) the tare barcode labels. This add-on enables POS to read a tare barcode. Reading a barcode makes POS adjust the weight of the latest article in the order list. The new weight is equal to the total weight minus the tare weight. The price is updated accordingly to the weight change.

Fkawala · 2020-01-28T08:53:39Z

Hello @robinkeunen, hello @legalsylvain, would you please have time to give a look at this PR? Thx!

legalsylvain

Hi @Fkawala.

thanks a lot for sharing this module.

some comments inline. no important blockings points.

FYI, I wrote a module for V12, named pos_tare. Complementary features.
maybe we could imagine to merge that feature in a second step.

could you take a look, and make a review ?
Thanks !
#436

pos_barcode_tare/static/src/js/pos_barcode_tare.js

pos_barcode_tare/models/pos_config.py

pos_barcode_tare/static/src/js/pos_barcode_tare.js

pos_barcode_tare/static/src/xml/pos_barcode_tare.xml

pos_barcode_tare/readme/DESCRIPTION.rst

robinkeunen · 2020-01-29T07:25:04Z

@vvrossem @houssine78 fyi

Fkawala · 2020-01-29T09:51:35Z

Hello @legalsylvain,

Thank you for the thoughtful review! I'll (try to) do the same for #436.

I agree with you #447 and #436 are complementary and should merge at some point!

Thank you,
François

Hi @Fkawala.

thanks a lot for sharing this module.

some comments inline. no important blockings points.

FYI, I wrote a module for V12, named pos_tare. Complementary features.
maybe we could imagine to merge that feature in a second step.

could you take a look, and make a review ?
Thanks !
#436

Fkawala · 2020-01-30T08:32:37Z

Howdy @robinkeunen @vvrossem @houssine78 a review would be much appreciated.

houssine78 · 2020-02-01T15:44:26Z

Hi @Fkawala Thanks for this very nice contribution. I don't know this POS part enough to give relevant comment. However the whole module seems to be good. I didn't went through the js code sorry. @vvrossem will probably give you a better review than mine.

Fkawala · 2020-02-04T00:29:01Z

Hi @legalsylvain, would you have time to take a look? I updated the code using the UOM as you do in #436. You'll need to define a "Kg" UOM if you plan to test that using the debug module. The UOM matching is case sensitive and the debug panel sets the weight to "Kg" whereas it should be "kg" (see https://github.com/odoo/odoo/blob/9.0/addons/point_of_sale/static/src/js/devices.js#L380).

Fkawala · 2020-02-04T00:38:34Z

Hi @robinkeunen! I would love to get that addon running in our shop. This addon would massively speed up the checkout process. This is one of our highest pain-point right now. Would you mind to check if someone from coopITEasycould can review this? Thank you in advance!

vvrossem · 2020-02-04T11:58:49Z

Hi @legalsylvain, would you have time to take a look? I updated the code using the UOM as you do in #436. You'll need to define a "Kg" UOM if you plan to test that using the debug module. The UOM matching is case sensitive and the debug panel sets the weight to "Kg" whereas it should be "kg" (see https://github.com/odoo/odoo/blob/9.0/addons/point_of_sale/static/src/js/devices.js#L380).

Hi @Fkawala, could you please explain me what happens if you put 'kg' instead of 'Kg' ?
Many thanks

Fkawala · 2020-02-04T12:57:03Z

@vvrossem, thank you for looking into this PR. Please find a more detail explanation below.

How the Addon works?

The add-on saves weight on the tare label using the "kg" unit of measure (UOM). This UOM should exist for the add-on to work. The UOM is fetched from the POS and matched by its name (case sensitive). See here and there for the code responsible to find the UOM based on UOM name.

When the electronic scale sends the weight, it comes with the unit name, for instance, "kg". The add-on fetches the UOM corresponding to the unit name. The UOM that matches the unit name sent by the scale is the "scale UOM". The add-on converts the scale weight from the scale UOM to the "kg" UOM. At this point, we're ready to create a tare label. When we read the tare label, we read a tare weight saved in "kg" UOM. We convert that tare weight into the product UOM so that we can compute the net weight in the product UOM.

In summary, we have three UOM:

Product UOM (fetch from the last product in order list)
Tare label UOM (which is always equal to the default "kg" reference UOM)
Electronic scale UOM (matched from the unit name sent by the electronic scale)

Today all the electronic scales that are supported (ADAM / Mettler-Toledo) use the "kg" UOM. However, this architecture would allow us to use an electronic scale that use another UOM, as long as this UOM is defined.

What can be the problem in debug?

My note on the "Kg" UOM is there because of the particular behavior of the "debug panel". As you can see here the debug pannel forges weights with a non-standard unit name "Kg". If you do run this code using the debug panel to moke the electronic scale, then the add-on will search for the "Kg" UOM. This UOM does not exist by default. Hence the add-on would fail to create a tare label.

I hope this is clear enough, if not, please let me know!

legalsylvain · 2020-02-13T11:28:22Z

I'll add the demo data (ie. missing UOM) that's a good idea.

nice !

How should we proceed to merge both our modules?
Would you be willing to do the migration work to get the result working on odoo 12.0?

i propose to :

merge this PR in 9.0, if you consider it as finished. 9.0 serie is quite old (unsupported recently)
integrate on [12.0] [ADD] pos_tare #436 the feature present in this module. do you have a deadline ? I'd like to do it, but I'm currently quite busy in the next weeks.

kind regards.

Fkawala · 2020-02-13T12:02:30Z

It works for me! The plan looks fine, thank you. We're running odoo 9.0. It won't change in the coming months. Hence, there is no rush to get that working on 12.0 (for us at least). Would you happen to know someone that could do the second review and approve the merge of this PR?

legalsylvain · 2020-02-13T12:27:33Z

@PierrickBrun could you take a time to make a little functional review on that PR ?
Thanks !

Fkawala · 2020-02-14T07:04:19Z

Hello @legalsylvain and @PierrickBrun. This is ready to be reviewed and hopefully merged. Thank you in advance!

OCA-git-bot · 2020-02-14T10:00:02Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Fkawala · 2020-02-14T10:03:20Z

Thanks for the review @PierrickBrun! Could we proceed forward and merge this? Best regards

legalsylvain · 2020-02-14T10:49:52Z

/ocabot merge

OCA-git-bot · 2020-02-14T10:50:23Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 9.0-ocabot-merge-pr-447-by-legalsylvain-bump-no, awaiting test results.

Signed-off-by legalsylvain

Fkawala · 2020-02-14T10:52:42Z

Thank you @legalsylvain !

vvrossem

Hi @Fkawala ! First of all, thank you for your work !
I've tested and reviewed the module. I have minor suggestions that can be added in the roadmap if the community agrees :)

vvrossem · 2020-02-14T09:59:41Z

pos_barcode_tare/static/src/js/pos_barcode_tare.js

+            barcode_tare_action: function (code) {
+                try {
+                    var order = this.pos.get_order();
+                    var last_order_line = order.get_last_orderline();


I suggest to replace order.get_last_orderline() with order.get_selected_orderline(). It allows the cashier to scan the tare of a pot after another orderline has been added :

I agree this would be quite more flexible!

vvrossem · 2020-02-14T10:32:33Z

pos_barcode_tare/static/src/js/pos_barcode_tare.js

+                return self.pos.proxy.scale_read().then(function (weight) {
+                    try {
+                        self.set_weight(weight);
+                    } catch (error) {


could the syntax scale_read().then(function (onFulfilled){...}, function (onRejected){...}) be an alternative for UOM management? scale_read in point_of_sale.devices uses it

I do not get the rationale here, could you please explain it to me? Thank you.

On a first opinion, I was thinking it would be better to move the UOM management in an overridden scale_read function, but my second opinion is that it's better to handle this on the TareScreenWidget and not in the ProxyDevice

vvrossem · 2020-02-14T10:41:59Z

pos_barcode_tare/readme/USAGE.rst

+
+The command line to start a chrome base browser in kiosk mode with silent printing looks like:
+
+``chromium-browser --use-system-default-printer --kiosk --kiosk-printing http://localhost:8069/``


I would also add a Configuration section explaining to check the show tare label button checkbox in Loose good options for the functional users

I agree this can help and it is fairly straightforward.

vvrossem · 2020-02-14T10:51:07Z

pos_barcode_tare/static/src/xml/pos_barcode_tare.xml

+                    <li class="info">
+                        tare = <t t-esc="line.get_tare_str_with_unit()" />
+                    </li>
+                </t>


Since the tare and net weight is specified on the orderline, I wonder if the gross weight should be included as well for legal reasons

We can add it, it does not cost much. But I think this would be less readable. I'm not too worried about legal compliance since the whole POS scaling hasn't been certified (at least not in UE).

OCA-git-bot · 2020-02-14T11:15:20Z

Congratulations, your PR was merged at ccb42d6. Thanks a lot for contributing to OCA. ❤️

Fkawala · 2020-02-14T13:06:05Z

@vvrossem What would the procedure to ship the changes you suggested to do (now that this PR has been merged)? Thanks!

legalsylvain · 2020-02-14T15:25:18Z

@vvrossem could you make a new PR agains 9.0 with all the nice improvments you propose ?
Thanks

Fkawala added 6 commits January 20, 2020 23:57

Barcode tare.

355cb8d

OCA guidelines.

2a1c8c0

Barcode tare.

95b60c6

OCA guidelines.

776fd95

Merge branch '9.0-tare' of github.com:Fkawala/pos into 9.0-tare

c5906d3

Fix doc.

997cb32

Fix PEP8.

4ae35f4

legalsylvain requested changes Jan 28, 2020

View reviewed changes

Fkawala added 2 commits January 29, 2020 08:27

Correct namespace + removed console log.

c237a31

Correct model naming.

25ee7f4

Fkawala changed the title ~~[9.0] [ADD] sell loose good using tare barcode label~~ [9.0] [ADD] sell loose goods using tare barcode label Jan 29, 2020

Fkawala added 3 commits January 29, 2020 09:30

Better readme.

b43c5d7

On single namespace.

c4a4cb2

Fix missing _t.

8a12de4

Barcode prefix is read from barcode parser.

51a0a82

Fkawala requested a review from legalsylvain January 30, 2020 08:31

Fix readme.

cd4a460

Fkawala added 2 commits February 4, 2020 00:15

Apply tare according to the product's unit of measure.

5e1edaa

Add French translation.

ad530c6

Fkawala added 2 commits February 4, 2020 09:20

use self only when needed.

05765a0

removed useless fonction parameter.

8cc2940

legalsylvain mentioned this pull request Feb 13, 2020

[12.0] [ADD] pos_tare #436

Closed

Fkawala added 2 commits February 14, 2020 07:58

Added: demo UOM, better errors, i18n.

bda9a25

Fix i18n.

d0ca9b9

PierrickBrun approved these changes Feb 14, 2020

View reviewed changes

OCA-git-bot added the approved label Feb 14, 2020

Fkawala removed request for hbrunn and robinkeunen February 14, 2020 09:49

OCA-git-bot added the ready to merge label Feb 14, 2020

OCA-git-bot added a commit that referenced this pull request Feb 14, 2020

Merge PR #447 into 9.0

94bad71

Signed-off-by legalsylvain

vvrossem approved these changes Feb 14, 2020

View reviewed changes

OCA-git-bot merged commit d0ca9b9 into OCA:9.0 Feb 14, 2020

OCA-git-bot added the merged 🎉 label Feb 14, 2020

OCA-git-bot changed the title ~~[9.0] [ADD] sell loose goods using tare barcode label~~ [9.0] [ADD] sell loose goods using tare barcode label Feb 14, 2020

Fkawala mentioned this pull request Feb 18, 2020

[9.0] [ADD] Reset search after click on product. #443

Merged

Fkawala deleted the 9.0-tare branch February 18, 2020 17:47

Fkawala mentioned this pull request Mar 28, 2020

[9.0] [ADD] Self service scale for loose goods and products sold by weight #470

Closed

Fkawala mentioned this pull request May 17, 2020

[12.0][MIG] pos_tare w/ barcode #491

Merged

Fkawala mentioned this pull request Aug 27, 2020

[12.0][MIG] pos_tare_generate_barcode #527

Closed


		The command line to start a chrome base browser in kiosk mode with silent printing looks like:

		``chromium-browser --use-system-default-printer --kiosk --kiosk-printing http://localhost:8069/``

Uh oh!

Conversation

Fkawala commented Jan 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Fkawala commented Jan 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

legalsylvain left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

robinkeunen commented Jan 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Fkawala commented Jan 29, 2020

Uh oh!

Fkawala commented Jan 30, 2020

Uh oh!

houssine78 commented Feb 1, 2020

Uh oh!

Fkawala commented Feb 4, 2020

Uh oh!

Fkawala commented Feb 4, 2020

Uh oh!

vvrossem commented Feb 4, 2020

Uh oh!

Fkawala commented Feb 4, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How the Addon works?

What can be the problem in debug?

Uh oh!

legalsylvain commented Feb 13, 2020

Uh oh!

Fkawala commented Feb 13, 2020 via email • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

legalsylvain commented Feb 13, 2020

Uh oh!

Fkawala commented Feb 14, 2020

Uh oh!

OCA-git-bot commented Feb 14, 2020

Uh oh!

Fkawala commented Feb 14, 2020

Uh oh!

legalsylvain commented Feb 14, 2020

Uh oh!

OCA-git-bot commented Feb 14, 2020

Uh oh!

Fkawala commented Feb 14, 2020

Uh oh!

vvrossem left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Fkawala Feb 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Fkawala commented Jan 28, 2020 •

edited

Loading

Fkawala commented Jan 28, 2020 •

edited

Loading

robinkeunen commented Jan 29, 2020 •

edited

Loading

Fkawala commented Feb 4, 2020 •

edited

Loading

Fkawala commented Feb 13, 2020 via email •

edited

Loading

Fkawala Feb 14, 2020 •

edited

Loading

Fkawala commented Feb 14, 2020 •

edited

Loading