Skip to content

[18.0][MIG] hr_expense_petty_cash#306

Open
BhaveshHeliconia wants to merge 24 commits intoOCA:18.0from
HeliconiaIO:18.0-mig-hr_expense_petty_cash
Open

[18.0][MIG] hr_expense_petty_cash#306
BhaveshHeliconia wants to merge 24 commits intoOCA:18.0from
HeliconiaIO:18.0-mig-hr_expense_petty_cash

Conversation

@BhaveshHeliconia
Copy link

@BhaveshHeliconia BhaveshHeliconia commented Jun 19, 2025

No description provided.

@BhaveshHeliconia BhaveshHeliconia changed the title 18.0 mig hr expense petty cash [18.0][MIG] hr_expense_petty_cash Jun 20, 2025
@BhaveshHeliconia BhaveshHeliconia force-pushed the 18.0-mig-hr_expense_petty_cash branch from c8112e6 to d7d00e8 Compare July 25, 2025 07:15
@github-actions
Copy link

github-actions bot commented Nov 23, 2025

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 23, 2025
@BhaveshHeliconia BhaveshHeliconia force-pushed the 18.0-mig-hr_expense_petty_cash branch from d7d00e8 to 7dd34cc Compare November 25, 2025 08:29
@hitrosol
Copy link

hitrosol commented Nov 26, 2025

I try this on runboat.
I can't make payment for the petty cash expense report.
Screen Shot 2025-11-26 at 7 47 34 PM

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 30, 2025
@TheerayutEncoder
Copy link
Member

TheerayutEncoder commented Dec 11, 2025

I try this on runboat. I can't make payment for the petty cash expense report. Screen Shot 2025-11-26 at 7 47 34 PM

After discussing with the functional team, for petty cash, we don't have to create a payment.
because it already creates Journal Entry, not Vendor Bill

So the step should be (on Expense Report)

  1. Submit to manager
  2. Approve
  3. Post Journal Entries
    Expense report will be switch status to Done

@TheerayutEncoder
Copy link
Member

TheerayutEncoder commented Dec 11, 2025 •
edited
Loading

Hi @BhaveshHeliconia please check on PR.

HeliconiaIO#1

Does it possible to merge into this PR so we will test it again?

@BhaveshHeliconia
Copy link
Author

BhaveshHeliconia commented Dec 11, 2025

@TheerayutEncoder : I’ve merged it. Now we need to test the flow and functionality — if everything works correctly, we can move forward and update the test cases based on the new flow. Thanks for the fix!

@BhaveshHeliconia
Copy link
Author

BhaveshHeliconia commented Dec 11, 2025

ping @hitrosol

@hitrosol
Copy link

hitrosol commented Dec 11, 2025

nice, it works now.

@TheerayutEncoder
Copy link
Member

TheerayutEncoder commented Dec 11, 2025

A little bit improvement, I just check test script have an error
and fixed by this PR: HeliconiaIO#2

Please check @BhaveshHeliconia

TheerayutEncoder
TheerayutEncoder approved these changes Dec 11, 2025
View reviewed changes
Copy link
Member

@TheerayutEncoder TheerayutEncoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional Test 👍

@Saran440
Copy link
Member

Saran440 commented Dec 15, 2025

/ocabot migration hr_expense_petty_cash

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Dec 15, 2025
@OCA-git-bot OCA-git-bot mentioned this pull request Dec 15, 2025
Open
10 tasks
ps-tubtim and others added 13 commits March 13, 2026 09:12
mymage and others added 11 commits March 13, 2026 09:12
@mymage @BhaveshHeliconia
Added translation using Weblate (Italian)
e41bafa
@mymage @BhaveshHeliconia
Translated using Weblate (Italian)
56ec7f9 
Currently translated at 100.0% (35 of 35 strings)

Translation: hr-expense-15.0/hr-expense-15.0-hr_expense_petty_cash
Translate-URL: https://translation.odoo-community.org/projects/hr-expense-15-0/hr-expense-15-0-hr_expense_petty_cash/it/
@francesco-ooops @BhaveshHeliconia
Translated using Weblate (Italian)
1a61e88 
Currently translated at 100.0% (35 of 35 strings)

Translation: hr-expense-15.0/hr-expense-15.0-hr_expense_petty_cash
Translate-URL: https://translation.odoo-community.org/projects/hr-expense-15-0/hr-expense-15-0-hr_expense_petty_cash/it/
@francesco-ooops @BhaveshHeliconia
Translated using Weblate (Italian)
96d9407 
Currently translated at 100.0% (35 of 35 strings)

Translation: hr-expense-15.0/hr-expense-15.0-hr_expense_petty_cash
Translate-URL: https://translation.odoo-community.org/projects/hr-expense-15-0/hr-expense-15-0-hr_expense_petty_cash/it/
@ps-tubtim @BhaveshHeliconia
[FIX] hr_expense_petty_cash: group by petty cash holder
3f3bf54
@ps-tubtim @BhaveshHeliconia
[FIX] hr_expense_petty_cash: add permission for internal user
6dae0d6
@Ivorra78 @BhaveshHeliconia
Added translation using Weblate (Spanish)
5395d07
@Ivorra78 @BhaveshHeliconia
Translated using Weblate (Spanish)
007c6ab 
Currently translated at 100.0% (35 of 35 strings)

Translation: hr-expense-15.0/hr-expense-15.0-hr_expense_petty_cash
Translate-URL: https://translation.odoo-community.org/projects/hr-expense-15-0/hr-expense-15-0-hr_expense_petty_cash/es/
@Saran440 @BhaveshHeliconia
[ENH] hr_expense_petty_cash: multi-company
2266b30
@BhaveshHeliconia
[IMP] hr_expense_petty_cash: pre-commit auto fixes
71554c9
@BhaveshHeliconia
[MIG] hr_expense_petty_cash: Migration to 18.0
1339609
@BhaveshHeliconia BhaveshHeliconia force-pushed the 18.0-mig-hr_expense_petty_cash branch from 7ee5453 to 1339609 Compare March 13, 2026 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@TheerayutEncoder TheerayutEncoder TheerayutEncoder approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

18.0

Development

Successfully merging this pull request may close these issues.