[MIG] hr_expense_petty_cash: Migration to 18.0

Author: BhaveshHeliconia

hr_expense_petty_cash/README.rst

@@ -7,7 +7,7 @@ Petty Cash
    !! This file is generated by oca-gen-addon-readme !!
    !! changes will be overwritten.                   !!
    !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
-   !! source digest: sha256:a8e609f561678619e4aacdc07e108e03b21d6921467844c68615b6c1a7bcf0b1
+   !! source digest: sha256:b0ac8e37253106681f342556f00a62710fa4e139ec09806af5b472e7466e9aa5
    !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
 
 .. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png
@@ -17,13 +17,13 @@ Petty Cash
     :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
     :alt: License: AGPL-3
 .. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fhr--expense-lightgray.png?logo=github
-    :target: https://github.com/OCA/hr-expense/tree/18.0/hr_expense_petty_cash
+    :target: https://github.com/OCA/hr-expense/tree/16.0/hr_expense_petty_cash
     :alt: OCA/hr-expense
 .. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png
-    :target: https://translation.odoo-community.org/projects/hr-expense-18-0/hr-expense-18-0-hr_expense_petty_cash
+    :target: https://translation.odoo-community.org/projects/hr-expense-16-0/hr-expense-16-0-hr_expense_petty_cash
     :alt: Translate me on Weblate
 .. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png
-    :target: https://runboat.odoo-community.org/builds?repo=OCA/hr-expense&target_branch=18.0
+    :target: https://runboat.odoo-community.org/builds?repo=OCA/hr-expense&target_branch=16.0
     :alt: Try me on Runboat
 
 |badge1| |badge2| |badge3| |badge4| |badge5|
@@ -32,13 +32,10 @@ This module work about expense that paid by petty cash.
 
 General Process:
 
-1. Create Petty Cash Holder
-2. Transfer cash to Petty Cash Holder (by using Vendor Bill)
-3. You can create expense paid by petty cash and select petty cash
-   holder.
-4. Then balance of petty cash holder less than amount of expense, you
-   must transfer cash to petty cash holder before Submit Report to
-   Manager.
+#. Create Petty Cash Holder
+#. Transfer cash to Petty Cash Holder (by using Vendor Bill)
+#. You can create expense paid by petty cash and select petty cash holder.
+#. Then balance of petty cash holder less than amount of expense, you must transfer cash to petty cash holder before Submit Report to Manager.
 
 **Table of contents**
 
@@ -50,79 +47,77 @@ Configuration
 
 **Create a Petty Cash Account**
 
-1. Go to Invoicing > Accounting > Petty Cash
-2. Create a new petty cash account
-3. Type = Bank and Cash or Account type that is asset
+#. Go to Invoicing > Accounting > Petty Cash
+#. Create a new petty cash account
+#. Type = Bank and Cash or Account type that is asset
 
 Note:
 
-- You will need the "Show Full Accounting Features" to see accounting
-  data
+* You will need the "Show Full Accounting Features" to see accounting data
 
 Usage
 =====
 
 **Create a Petty Cash Holder**
 
-1. Go to Invoicing > Accounting > Petty Cash
-2. Create a new petty cash holder
-3. Select Petty Cash Account and Journal (optional)
+#. Go to Invoicing > Accounting > Petty Cash
+#. Create a new petty cash holder
+#. Select Petty Cash Account and Journal (optional)
 
 **Add Balance for Petty Cash Holder**
 
-1. Go to Invoicing > Vendor > Bill
-2. Create a new vendor bill
-3. Select Vendor (Petty Cash Holder)
-4. Check Petty Cash will auto line with Unit Price = Max Limit - Balance
+#. Go to Invoicing > Vendor > Bill
+#. Create a new vendor bill
+#. Select Vendor (Petty Cash Holder)
+#. Check Petty Cash will auto line with Unit Price = Max Limit - Balance
 
 **Create an Expense paid by Petty Cash**
 
-1. Go to Expenses > My Expenses
-2. Create a new expense
-3. Select Paid by = Petty Cash and Select Petty Cash Holder
+#. Go to Expenses > My Expenses
+#. Create a new expense
+#. Select Paid by = Petty Cash and Select Petty Cash Holder
 
 **Create an Expense Report paid by Petty Cash**
 
-1. Go to Expenses > My Expense Reports
-2. Create a new expense report
-3. Select or Create expenses Paid by Petty Cash and same Petty Cash
-   Holder
+#. Go to Expenses > My Expense Reports
+#. Create a new expense report
+#. Select or Create expenses Paid by Petty Cash and same Petty Cash Holder
 
-Note : Bill and Expense will default journal from petty cash holder, if
-you configure journal in petty cash holder.
+Note : Bill and Expense will default journal from petty cash holder,
+if you configure journal in petty cash holder.
 
 Bug Tracker
 ===========
 
 Bugs are tracked on `GitHub Issues <https://github.com/OCA/hr-expense/issues>`_.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-`feedback <https://github.com/OCA/hr-expense/issues/new?body=module:%20hr_expense_petty_cash%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
+`feedback <https://github.com/OCA/hr-expense/issues/new?body=module:%20hr_expense_petty_cash%0Aversion:%2016.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
 
 Do not contact contributors directly about support or help with technical issues.
 
 Credits
 =======
 
 Authors
--------
+~~~~~~~
 
 * Ecosoft
 
 Contributors
-------------
+~~~~~~~~~~~~
 
-- `Ecosoft <http://ecosoft.co.th>`__:
+* `Ecosoft <http://ecosoft.co.th>`__:
 
-  - Pimolnat Suntian <[email protected]>
-  - Saran Lim. <[email protected]>
+  * Pimolnat Suntian <[email protected]>
+  * Saran Lim. <[email protected]>
 
-- `Trinityroots <http://trinityroots.co.th>`__:
+* `Trinityroots <http://trinityroots.co.th>`__:
 
-  - Santi Techatoo <[email protected]>
+  * Santi Techatoo <[email protected]>
 
 Maintainers
------------
+~~~~~~~~~~~
 
 This module is maintained by the OCA.
 
@@ -134,6 +129,6 @@ OCA, or the Odoo Community Association, is a nonprofit organization whose
 mission is to support the collaborative development of Odoo features and
 promote its widespread use.
 
-This module is part of the `OCA/hr-expense <https://github.com/OCA/hr-expense/tree/18.0/hr_expense_petty_cash>`_ project on GitHub.
+This module is part of the `OCA/hr-expense <https://github.com/OCA/hr-expense/tree/16.0/hr_expense_petty_cash>`_ project on GitHub.
 
 You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.

hr_expense_petty_cash/__manifest__.py

@@ -3,7 +3,7 @@
 
 {
     "name": "Petty Cash",
-    "version": "15.0.2.0.0",
+    "version": "18.0.1.0.0",
     "category": "Human Resources",
     "author": "Ecosoft, Odoo Community Association (OCA)",
     "license": "AGPL-3",

hr_expense_petty_cash/i18n/es.po

@@ -45,12 +45,6 @@ msgstr "Archivado"
 msgid "Balance"
 msgstr "Saldo"
 
-#. module: hr_expense_petty_cash
-#: model:ir.model.fields,field_description:hr_expense_petty_cash.field_petty_cash__company_id
-#: model_terms:ir.ui.view,arch_db:hr_expense_petty_cash.view_petty_cash_search
-msgid "Company"
-msgstr ""
-
 #. module: hr_expense_petty_cash
 #: model_terms:ir.actions.act_window,help:hr_expense_petty_cash.action_petty_cash
 msgid "Create a new petty cash holder"
@@ -132,12 +126,11 @@ msgstr "Límite Máximo"
 #, python-format
 msgid ""
 "Not enough money in petty cash holder.\n"
-"You are requesting {amount_company}{symbol}, but the balance is {balance}"
-"{symbol}."
+"You are requesting {amount_company}{symbol}, but the balance is {balance}{symbol}."
 msgstr ""
 "No hay suficiente dinero en la caja para gastos menores.\n"
-"Está solicitando {amount_company}{symbol}, pero el saldo es {balance}"
-"{symbol}."
+"Está solicitando {amount_company}{symbol}, pero el saldo es "
+"{balance}{symbol}."
 
 #. module: hr_expense_petty_cash
 #: model:ir.model.fields,field_description:hr_expense_petty_cash.field_hr_expense__payment_mode

hr_expense_petty_cash/i18n/hr_expense_petty_cash.pot

@@ -42,12 +42,6 @@ msgstr ""
 msgid "Balance"
 msgstr ""
 
-#. module: hr_expense_petty_cash
-#: model:ir.model.fields,field_description:hr_expense_petty_cash.field_petty_cash__company_id
-#: model_terms:ir.ui.view,arch_db:hr_expense_petty_cash.view_petty_cash_search
-msgid "Company"
-msgstr ""
-
 #. module: hr_expense_petty_cash
 #: model_terms:ir.actions.act_window,help:hr_expense_petty_cash.action_petty_cash
 msgid "Create a new petty cash holder"

hr_expense_petty_cash/i18n/it.po

@@ -45,12 +45,6 @@ msgstr "In archivio"
 msgid "Balance"
 msgstr "Saldo"
 
-#. module: hr_expense_petty_cash
-#: model:ir.model.fields,field_description:hr_expense_petty_cash.field_petty_cash__company_id
-#: model_terms:ir.ui.view,arch_db:hr_expense_petty_cash.view_petty_cash_search
-msgid "Company"
-msgstr ""
-
 #. module: hr_expense_petty_cash
 #: model_terms:ir.actions.act_window,help:hr_expense_petty_cash.action_petty_cash
 msgid "Create a new petty cash holder"

hr_expense_petty_cash/models/account_move.py

@@ -1,19 +1,15 @@
 # Copyright 2019 Ecosoft Co., Ltd. (http://ecosoft.co.th)
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
 
-from odoo import _, api, fields, models
+from odoo import api, fields, models
 from odoo.exceptions import UserError, ValidationError
 from odoo.tools import float_compare
 
 
 class AccountMove(models.Model):
     _inherit = "account.move"
 
-    is_petty_cash = fields.Boolean(
-        string="Petty Cash",
-        readonly=True,
-        states={"draft": [("readonly", False)]},
-    )
+    is_petty_cash = fields.Boolean(string="Petty Cash")
 
     def action_post(self):
         self._check_petty_cash_amount()
@@ -38,30 +34,32 @@ def _check_petty_cash_amount(self):
                     and account.id in rec.invoice_line_ids.mapped("account_id").ids
                 ):
                     raise UserError(
-                        _("Please check Petty Cash on {name}.").format(
+                        self.env._("Please check Petty Cash on {name}.").format(
                             name=rec.display_name
                         )
                     )
                 if rec.is_petty_cash:
                     if len(rec.invoice_line_ids) > 1:
                         raise UserError(
-                            _(
+                            self.env._(
                                 "{name} with petty cash checked must contain "
                                 "only 1 line."
                             ).format(name=rec.display_name)
                         )
                     if rec.invoice_line_ids.account_id.id != account.id:
                         raise UserError(
-                            _("Account on invoice line should be {name}.").format(
-                                name=account.display_name
-                            )
+                            self.env._(
+                                "Account on invoice line should be {name}."
+                            ).format(name=account.display_name)
                         )
                     balance = petty_cash.petty_cash_balance
                     limit = petty_cash.petty_cash_limit
                     max_amount = limit - balance
                     amount = sum(
                         rec.invoice_line_ids.filtered(
-                            lambda line, acc=account: line.account_id == acc
+                            lambda inv_line, _account=account: (
+                                inv_line.account_id == _account
+                            )
                         ).mapped("price_subtotal")
                     )
                     company_currency = rec.company_id.currency_id
@@ -79,7 +77,7 @@ def _check_petty_cash_amount(self):
                         == 1
                     ):
                         raise ValidationError(
-                            _(
+                            self.env._(
                                 "Petty Cash balance is {balance} {symbol}.\n"
                                 "Max amount to add is {max_amount} {symbol}."
                             ).format(
@@ -108,6 +106,7 @@ def _add_petty_cash_invoice_line(self, petty_cash):
                 "partner_id": petty_cash.partner_id.id,
                 "price_unit": amount_doc_currency,
                 "quantity": 1,
+                "tax_ids": [],  # no tax need
             }
         )
         return inv_line
@@ -118,7 +117,7 @@ def _onchange_is_petty_cash(self):
         self.invoice_line_ids = False
         if self.is_petty_cash:
             if not self.partner_id:
-                raise ValidationError(_("Please select petty cash holder"))
+                raise ValidationError(self.env._("Please select petty cash holder"))
             # Selected partner must be petty cash holder
             petty_cash = self.env["petty.cash"].search(
                 [
@@ -129,12 +128,10 @@ def _onchange_is_petty_cash(self):
             )
             if not petty_cash:
                 raise ValidationError(
-                    _("%s is not a petty cash holder") % self.partner_id.name
+                    self.env._("%s is not a petty cash holder") % self.partner_id.name
                 )
             self.invoice_line_ids = self._add_petty_cash_invoice_line(petty_cash)
-            self._onchange_invoice_line_ids()
-            self.line_ids._onchange_price_subtotal()
-            self._onchange_recompute_dynamic_lines()
+
             if petty_cash.journal_id:
                 # Prevent inconsistent journal_id
                 if (