Skip to content

[18.0][IMP] removing automatic date_start to today when subscription goes i… #1401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cvinh wants to merge 1 commit into
base: 18.0
Choose a base branch
from
+0 −1
Open

[18.0][IMP] removing automatic date_start to today when subscription goes i… #1401

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion subscription_oca/models/sale_subscription.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,7 +453,6 @@ def write(self, values):
if record.stage_id.type == "in_progress":
record.in_progress = True
today = date.today()
record.date_start = today
Copy link

@rrebollo rrebollo Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My concern is: what if record.date_start is not set? I checked and it's not a required field.

Maybe you could remove the assignment only for records that already have a value set for the date_start field. Though it's possible the scenario I'm describing isn't a valid one.

record.calculate_recurring_next_date(today)
elif record.stage_id.type == "post":
record.close_reason_id = values.get("close_reason_id", False)
Expand Down