[18.0][IMP] removing automatic date_start to today when subscription goes i…#1401
Open
[18.0][IMP] removing automatic date_start to today when subscription goes i…#1401
Conversation
…n progress. This could be useful when we launch a subscription with a date start different from today
|
@cvinh PR title should be something along [18.0][IMP] subscription_oca: .... |
rrebollo
reviewed
Mar 24, 2026
rrebollo
left a comment
rrebollo
left a comment
There was a problem hiding this comment.
Technically correct. Would you consider covering the modification with some tests? I'm guessing a small adjustment to one of the existing tests would work. Ping me then.
| if record.stage_id.type == "in_progress": | ||
| record.in_progress = True | ||
| today = date.today() | ||
| record.date_start = today |
There was a problem hiding this comment.
My concern is: what if record.date_start is not set? I checked and it's not a required field.
Maybe you could remove the assignment only for records that already have a value set for the date_start field. Though it's possible the scenario I'm describing isn't a valid one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…n progress. This could be useful when we launch a subscription with a date start different from today