Skip to content

[18.0][IMP] product_contract - remove unnecessary defaults #1315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anthonissen-a wants to merge 1 commit into
base: 18.0
Choose a base branch
from
+0 −8
Open

[18.0][IMP] product_contract - remove unnecessary defaults #1315

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions product_contract/models/sale_order_line_contract_mixin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,15 +36,13 @@ class SaleOrderLineContractMixin(models.AbstractModel):
("semesterly", "Semester(s)"),
("yearly", "Year(s)"),
],
default="monthly",
help="Specify Interval for contract duration.",
compute="_compute_product_contract_data",
precompute=True,
store=True,
readonly=False,
)
recurring_interval = fields.Integer(
default=1,
string="Invoice Every",
help="Invoice every (Days/Week/Month/Year)",
compute="_compute_product_contract_data",
Expand All @@ -62,7 +60,6 @@ class SaleOrderLineContractMixin(models.AbstractModel):
("semesterly", "Semester(s)"),
("yearly", "Year(s)"),
],
default="monthly",
string="Recurrence",
help="Specify Interval for automatic invoice generation.",
compute="_compute_product_contract_data",
Expand All @@ -72,7 +69,6 @@ class SaleOrderLineContractMixin(models.AbstractModel):
)
recurring_invoicing_type = fields.Selection(
[("pre-paid", "Pre-paid"), ("post-paid", "Post-paid")],
default="pre-paid",
string="Invoicing type",
help=(
"Specify if the invoice must be generated at the beginning "
Expand Down Expand Up @@ -104,12 +100,10 @@ class SaleOrderLineContractMixin(models.AbstractModel):
string="Auto Renew",
compute="_compute_product_contract_data",
precompute=True,
default=False,
store=True,
readonly=False,
)
auto_renew_interval = fields.Integer(
default=1,
string="Renew Every",
compute="_compute_product_contract_data",
precompute=True,
Expand All @@ -124,7 +118,6 @@ class SaleOrderLineContractMixin(models.AbstractModel):
("monthly", "Month(s)"),
("yearly", "Year(s)"),
],
default="yearly",
compute="_compute_product_contract_data",
precompute=True,
store=True,
Expand All @@ -141,7 +134,6 @@ class SaleOrderLineContractMixin(models.AbstractModel):
("end_next", "End of next period"),
],
"Start Date Method",
default="manual",
help="""This field allows to define how the start date of the contract will
be calculated:

Expand Down