[18.0][IMP] product_contract - remove unnecessary defaults

[anthonissen-a]

The default attributes are no longer necessary since the fields are set by the compute method with a precompute attribute.

[OCA-git-bot]

Hi @sbejaoui,
some modules you are maintaining are being modified, check this out!

[yvaucher]

👍

By the way according to odoo official doc, the default value disables the precompute.

[github-actions]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

[pedrobaeza]

Looking at the code, we are not going to have the proper value in the line init, as the compute is not assigning any default value.

[anthonissen-a]

Hi @pedrobaeza, thanks for your review.
Since the fields have precompute=True, the compute function will be triggered at line init. As @yvaucher mentioned, the tags default and precompute can't be used together because they have conflicting behaviors.

[pedrobaeza]

I understood the contrary: the default is applied instead of the compute.

[anthonissen-a]

Exactly, and therefore the default should be removed, to allow a proper use of the precompute.

[pedrobaeza]

But that can't be done if the compute is not providing the same default value, which is not the case.

[yvaucher]

@pedrobaeza Please read again the offical doc warning (see my post upper).

default and precompute are incompatible, thus one must go.

Are you saying that we should move the default values in the "init" values of the compute?

For instance 'recurring_interval: 1

It could make sense even for the compute acting as an onchange on the view that if you change the product to a non contract product. As you want plausible default values.

[pedrobaeza]

OK to renew the compute method

[anthonissen-a]

Do you have a case where these values are used in another context than with products of type contract ? Otherwise, the values of these fields will be overwritten by the compute when a product of type contract is set.