Skip to content

refactor: use structured logging instead of print in letter_counting_environment.py #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alireza78a wants to merge 2 commits into
base: main
Choose a base branch
from
Open

refactor: use structured logging instead of print in letter_counting_environment.py #384

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
894331d
refactor: replace print statements with logger in letter_counting_env…
alireza78a Feb 19, 2026
aebba98
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Feb 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions environments/letter_counting_environment/letter_counting_environment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@
)

# Default path to the YAML configuration file
logger = logging.getLogger(__name__)

DEFAULT_CONFIG_PATH = "config.yaml"


Expand Down Expand Up @@ -61,14 +63,14 @@ def get_config_path() -> str:
except LookupError:
nltk.download("words")
except ImportError:
print("Warning: NLTK not available. Please install with: pip install nltk")
logger.warning("NLTK not available. Please install with: pip install nltk")
words = None

# Import datasets for loading external eval dataset
try:
from datasets import load_dataset
except ImportError:
print("Warning: datasets library not available. Install with: pip install datasets")
logger.warning("datasets library not available. Install with: pip install datasets")
load_dataset = None


Expand Down Expand Up @@ -364,12 +366,14 @@ def config_init(cls) -> Tuple[LetterCountingConfig, List[APIServerConfig]]:
try:
with open(config_path, "r") as f:
config = yaml.safe_load(f) or {}
print(f"Loaded config from {config_path}")
logger.info(f"Loaded config from {config_path}")
except FileNotFoundError:
print(f"Config file not found at {config_path}, using defaults")
logger.warning(f"Config file not found at {config_path}, using defaults")
config = {}
except Exception as e:
print(f"Error loading config from {config_path}: {e}, using defaults")
logger.error(
f"Error loading config from {config_path}: {e}, using defaults"
)
config = {}

env = config.get("env", {})
Expand Down