refactor: use structured logging instead of print in letter_counting_environment.py#384
Open
alireza78a wants to merge 2 commits intoNousResearch:mainfrom
Open
Conversation
…ironment.py Replace all print() calls with proper logging: - Added module-level logger using logging.getLogger(__name__) - Import warnings: print() -> logger.warning() for missing NLTK and datasets - Config loading: print() -> logger.info/warning/error based on severity This ensures consistent logging behavior across the environment.
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace all
print()calls with properlogginginletter_counting_environment.py.Problem
The file uses
print()for config loading messages and import warnings, while already havingloggingimported and usingself.loggerelsewhere in the class.Changes
logger = logging.getLogger(__name__)print()calls with appropriate log levels:logger.warning()for missing optional dependencies (NLTK, datasets)logger.info()for successful config loadinglogger.warning()for missing config filelogger.error()for config parsing errorsTesting
pre-commitchecks passed