Skip to content

refactor: inline OutputConfigurationExtension into Infrastructure #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Notorious-Coding merged 1 commit into from
Apr 26, 2026
Merged

refactor: inline OutputConfigurationExtension into Infrastructure #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions NotoriousTest.Core/Extensions/OutputConfigurationExtension.cs
View file
Open in desktop

This file was deleted.

11 changes: 6 additions & 5 deletions NotoriousTest.Core/Infrastructures/Infrastructure.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
using NotoriousTest.Core.Configuration;
using NotoriousTest.Core.Extensions;
using NotoriousTest.Core.Logger;
using NotoriousTest.Core.Registry;

Expand All @@ -11,15 +10,17 @@ namespace NotoriousTest.Core.Infrastructures;
public abstract class Infrastructure<TOutputConfiguration, TMetadata> : Infrastructure<TMetadata>, IConfigurationProducer<TOutputConfiguration>
where TMetadata : class
{
public List<ConfigurationEntry<TOutputConfiguration>> OutputConfiguration => OutputConfigurationExtension.OutputConfiguration;
public List<ConfigurationEntry<TOutputConfiguration>> OutputConfiguration { get; } = new();

protected OutputConfigurationExtension<TOutputConfiguration> OutputConfigurationExtension { get; private set; }
protected Infrastructure(EnvironmentId contextId, ITestLogger logger, IRegistry provider) : base(contextId, logger, provider)
{
OutputConfigurationExtension = EnsureExtension(new OutputConfigurationExtension<TOutputConfiguration>());
}

public void AddEntry(string key, TOutputConfiguration value) => OutputConfigurationExtension.AddEntry(key, value);
public void AddEntry(string key, TOutputConfiguration value)
=> OutputConfiguration.Add(new ConfigurationEntry<TOutputConfiguration>(value, key));

public void AddEntry(TOutputConfiguration value)
=> OutputConfiguration.Add(new ConfigurationEntry<TOutputConfiguration>(value, value!.GetType().Name));
}

public abstract class Infrastructure<TMetadata> : Infrastructure where TMetadata : class
Expand Down
Loading